-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix room list cell highlighting issues, add unit tests #2432
Conversation
|
Generated by 🚫 Danger Swift against 33ed8ef |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2432 +/- ##
===========================================
- Coverage 72.90% 72.89% -0.01%
===========================================
Files 523 523
Lines 36244 36241 -3
Branches 17423 17422 -1
===========================================
- Hits 26422 26419 -3
- Misses 9180 9181 +1
+ Partials 642 641 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes the problem reported by Benoit here