Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix room list cell highlighting issues, add unit tests #2432

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

stefanceriu
Copy link
Member

Fixes the problem reported by Benoit here

  • highlights badges when the room is marked as unread but muted
  • adds unit tests to prevent us from breaking this rather complex logic

@stefanceriu stefanceriu requested a review from a team as a code owner February 8, 2024 08:11
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team February 8, 2024 08:11
Copy link

sonarqubecloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

github-actions bot commented Feb 8, 2024

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 33ed8ef

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c320152) 72.90% compared to head (33ed8ef) 72.89%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2432      +/-   ##
===========================================
- Coverage    72.90%   72.89%   -0.01%     
===========================================
  Files          523      523              
  Lines        36244    36241       -3     
  Branches     17423    17422       -1     
===========================================
- Hits         26422    26419       -3     
- Misses        9180     9181       +1     
+ Partials       642      641       -1     
Flag Coverage Δ
unittests 58.27% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu requested a review from Velin92 February 8, 2024 16:08
Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanceriu stefanceriu merged commit d7a190b into develop Feb 9, 2024
5 checks passed
@stefanceriu stefanceriu deleted the stefan/markUnreadMuteHighlight branch February 9, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants