-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RoomChangePermissionsScreen #2513
Conversation
Generated by 🚫 Danger Swift against 7b8817a |
d1120bd
to
1dd13de
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2513 +/- ##
=========================================
Coverage 75.23% 75.23%
=========================================
Files 530 535 +5
Lines 36848 37106 +258
Branches 17613 17613
=========================================
+ Hits 27721 27918 +197
- Misses 9127 9188 +61
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ElementX/Sources/Screens/RoomChangePermissionsScreen/RoomChangePermissionsScreenModels.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good but I would prefer we could remove those force unwrappings, not for the risk but because they are ugly, and we can definitely get rid of them very easily
Alright, I've added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
edeba4b
to
7b8817a
Compare
|
First part of #2358 this PR adds the screen and theoretically the VM implementation, but it isn't part of a flow yet, so is untested against a real room.