Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the SDK adopting new power levels APIs. #2545

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Update the SDK adopting new power levels APIs. #2545

merged 2 commits into from
Mar 8, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Mar 8, 2024 •
edited
Loading

We simplified the SDK to always get RoomPowerLevels and always apply RoomPowerLevelChanges. This means a load of gymnastics around optionals from #2513 is no longer necessary.

@pixlwave pixlwave requested a review from a team as a code owner March 8, 2024 12:23
@pixlwave pixlwave requested review from stefanceriu and removed request for a team March 8, 2024 12:23
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 8, 2024 •
edited
Loading

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.
⚠️

ElementX/Sources/FlowCoordinators/RoomRolesAndPermissionsFlowCoordinator.swift#L146 - Case statements should vertically align with their enclosing switch statement. (switch_case_alignment)
⚠️

ElementX/Sources/FlowCoordinators/RoomRolesAndPermissionsFlowCoordinator.swift#L147 - Case statements should vertically align with their enclosing switch statement. (switch_case_alignment)

Generated by 🚫 Danger Swift against 193a88b

stefanceriu
stefanceriu approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotta love simplifications!

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pixlwave pixlwave merged commit e36db7d into develop Mar 8, 2024
4 of 5 checks passed
@pixlwave pixlwave deleted the doug/sdk branch March 8, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanceriu stefanceriu stefanceriu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pixlwave @stefanceriu