Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analytics for Room Moderation. #2571

Merged
merged 5 commits into from
Mar 14, 2024
Merged

Conversation

pixlwave
Copy link
Member

This PR adds the analytics for #2358 #2356 and #2357.

Depends on matrix-org/matrix-analytics-events#91

@pixlwave pixlwave requested a review from a team as a code owner March 13, 2024 16:59
@pixlwave pixlwave requested review from stefanceriu and removed request for a team March 13, 2024 16:59
@pixlwave pixlwave force-pushed the doug/moderation-analytics branch from d2300b1 to bd695cc Compare March 13, 2024 17:00
Copy link

github-actions bot commented Mar 13, 2024

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.
⚠️

ElementX/Sources/FlowCoordinators/RoomRolesAndPermissionsFlowCoordinator.swift#L161 - Case statements should vertically align with their enclosing switch statement. (switch_case_alignment)

⚠️

ElementX/Sources/FlowCoordinators/RoomRolesAndPermissionsFlowCoordinator.swift#L162 - Case statements should vertically align with their enclosing switch statement. (switch_case_alignment)

⚠️

ElementX/Sources/Screens/RoomMemberListScreen/View/RoomMembersListManageMemberSheet.swift#L62 - TODOs should be resolved (Use the ideal height somehow?). (todo)

Generated by 🚫 Danger Swift against 987f61e

@pixlwave pixlwave force-pushed the doug/moderation-analytics branch from bd695cc to 2f0a703 Compare March 14, 2024 14:02
@pixlwave pixlwave force-pushed the doug/moderation-analytics branch from 2f0a703 to d3da96c Compare March 14, 2024 14:04
@pixlwave pixlwave force-pushed the doug/moderation-analytics branch from d3da96c to 987f61e Compare March 14, 2024 15:23
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 60.86957% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 74.77%. Comparing base (d2a9db8) to head (987f61e).

Files Patch % Lines
...geRolesScreen/RoomChangeRolesScreenViewModel.swift 35.71% 9 Missing ⚠️
...Sources/FlowCoordinators/RoomFlowCoordinator.swift 0.00% 8 Missing ⚠️
...ators/RoomRolesAndPermissionsFlowCoordinator.swift 0.00% 8 Missing ⚠️
...rListScreen/RoomMembersListScreenCoordinator.swift 0.00% 3 Missing ⚠️
...creen/RoomChangePermissionsScreenCoordinator.swift 0.00% 2 Missing ⚠️
...RolesScreen/RoomChangeRolesScreenCoordinator.swift 0.00% 2 Missing ⚠️
...een/RoomRolesAndPermissionsScreenCoordinator.swift 0.00% 2 Missing ⚠️
...ervices/Analytics/Helpers/RoomModerationRole.swift 80.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2571      +/-   ##
===========================================
+ Coverage    74.70%   74.77%   +0.07%     
===========================================
  Files          553      554       +1     
  Lines        38134    38203      +69     
  Branches     17337    17335       -2     
===========================================
+ Hits         28489    28568      +79     
+ Misses        9645     9635      -10     
Flag Coverage Δ
unittests 61.02% <60.86%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit c68ec2c into develop Mar 14, 2024
9 checks passed
@pixlwave pixlwave deleted the doug/moderation-analytics branch March 14, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants