Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIxes #2602 - Fix pushers not being registered on re-login after rece… #2623

Merged
merged 1 commit into from
Apr 2, 2024
Merged

FIxes #2602 - Fix pushers not being registered on re-login after rece… #2623

merged 1 commit into from
Apr 2, 2024

Conversation

stefanceriu
Copy link
Member

…nt Onboarding changes

Pull Request Checklist

UI changes have been tested with:

  • iPhone and iPad simulators in portrait and landscape orientations.
  • Dark mode enabled and disabled.
  • Various sizes of dynamic type.
  • Voiceover enabled.

@stefanceriu stefanceriu requested a review from a team as a code owner April 1, 2024 11:34
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team April 1, 2024 11:34
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

pixlwave
pixlwave approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@stefanceriu stefanceriu merged commit 2e6c5c0 into develop Apr 2, 2024
4 of 6 checks passed
@stefanceriu stefanceriu deleted the stefan/pushersFix branch April 2, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

@Velin92 Velin92 Awaiting requested review from Velin92 Velin92 is a code owner automatically assigned from element-hq/element-x-ios-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanceriu @pixlwave