Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix child presentation of the same room. #2669

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Apr 9, 2024

Make sure we don't stack the same room directly underneath itself (but allow it with intermediate rooms)

@pixlwave pixlwave requested a review from a team as a code owner April 9, 2024 09:51
@pixlwave pixlwave requested review from stefanceriu and removed request for a team April 9, 2024 09:51
Copy link

sonarqubecloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

github-actions bot commented Apr 9, 2024

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against d94e1d4

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice! 👌

@pixlwave pixlwave merged commit bc75fe1 into develop Apr 9, 2024
4 of 5 checks passed
@pixlwave pixlwave deleted the doug/permalink-to-same-room branch April 9, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants