Handle external links to a user. #2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against 2357dce |
pixlwave
force-pushed
the
doug/user-profile-permalink
branch
from
42e8967 to
ee9ae3d
Compare
Velin92
reviewed
Apr 15, 2024
ElementX/Sources/FlowCoordinators/UserSessionFlowCoordinatorStateMachine.swift
Outdated
Show resolved
Hide resolved
Velin92
reviewed
Apr 15, 2024
ElementX/Sources/Screens/RoomMemberDetailsScreen/RoomMemberDetailsScreenViewModel.swift
Outdated
Show resolved
Hide resolved
Velin92
reviewed
Apr 15, 2024
ElementX/Sources/Screens/UserProfileScreen/UserProfileScreenViewModel.swift
Show resolved
Hide resolved
Velin92
reviewed
Apr 15, 2024
Velin92
approved these changes
Apr 15, 2024
pixlwave
force-pushed
the
doug/user-profile-permalink
branch
from
ee9ae3d to
2357dce
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening the app via matrix.to, a link to a user will now dismiss the current room flow and present the user's profile in a sheet. There is a small conflict between this and #2689.
Part of this change involves handling links from the web app correctly too (we convert them to matrix.to links and reuse the existing parsing).