Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose paths for focusing replied-to timeline items by tapping on an in-reply-to message bubble #2698

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Expose paths for focusing replied-to timeline items by tapping on an in-reply-to message bubble #2698

merged 1 commit into from
Apr 16, 2024

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Apr 16, 2024 •
edited
Loading

No description provided.

@stefanceriu stefanceriu changed the title element-hq/element-x-ios/issues/2636 - Expose paths for focusing repl… Expose paths for focusing replied-to timeline items by tapping on an in-reply-to message bubble Apr 16, 2024
@stefanceriu stefanceriu requested a review from pixlwave April 16, 2024 06:25
@stefanceriu stefanceriu marked this pull request as ready for review April 16, 2024 06:25
@stefanceriu stefanceriu requested a review from a team as a code owner April 16, 2024 06:25
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 16, 2024 •
edited
Loading

Warnings
⚠️ Please provide a description for this PR.
⚠️ Please add a changelog.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 4be15ab

pixlwave
pixlwave approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you 🙏

pixlwave
pixlwave requested changes Apr 16, 2024
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a thought whilst working on the permalink side of things and came back to notice the below:

@stefanceriu stefanceriu force-pushed the stefan/permalinkAdditions branch from 89fc190 to 3f2ff5b Compare April 16, 2024 10:50
@stefanceriu stefanceriu requested a review from pixlwave April 16, 2024 10:55
pixlwave
pixlwave approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@stefanceriu stefanceriu force-pushed the stefan/permalinkAdditions branch from 3f2ff5b to 4be15ab Compare April 16, 2024 12:00
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
54.7% Duplication on New Code

See analysis details on SonarCloud

@stefanceriu stefanceriu merged commit 83c620d into develop Apr 16, 2024
5 checks passed
@stefanceriu stefanceriu deleted the stefan/permalinkAdditions branch April 16, 2024 12:01
@pixlwave pixlwave mentioned this pull request Apr 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanceriu @pixlwave