-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent the lock button for ending an ElementCall (#2) #3351
Conversation
stefanceriu
commented
Sep 30, 2024
- we can override the output through the shared AudioSession but it seems we need to do so after CallKit starts the call
- we can override the output through the shared AudioSession but it seems we need to do so after CallKit starts the call
Generated by 🚫 Danger Swift against 4aa136a |
|
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
func provider(_ provider: CXProvider, perform action: CXStartCallAction) { | ||
action.fulfill() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! 🤦♂️🤦♂️🤦♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess at least b is expected since when you lock the phone the camera is interrupted in calls generally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This happens straight away in the call, I didn't even press the lock button 😅
Superseded by #3372 |