Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent the lock button for ending an ElementCall (#2) #3351

Closed
wants to merge 1 commit into from

Conversation

stefanceriu
Copy link
Member

  • we can override the output through the shared AudioSession but it seems we need to do so after CallKit starts the call

- we can override the output through the shared AudioSession but it seems we need to do so after CallKit starts the call
@stefanceriu stefanceriu requested a review from a team as a code owner September 30, 2024 14:02
Copy link

Fails
🚫

Please add a pr- label to categorise the changelog entry.

Generated by 🚫 Danger Swift against 4aa136a

Copy link

Copy link

codecov bot commented Sep 30, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
676 1 675 0
View the top 1 failed tests by shortest run time
UserSessionFlowCoordinatorTests testRoomClearsStack()
Stack Traces | 0s run time
XCTAssertTrue failed (.../UnitTests/Sources/UserSessionFlowCoordinatorTests.swift:190)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Comment on lines +192 to +193
func provider(_ provider: CXProvider, perform action: CXStartCallAction) {
action.fulfill()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work for me. The very act of having this delegate method here (or fulfilling the action anyway) results in
a) A mic mute/unmute sound occurring at the start of the call
b) Black video feeds for both incoming and outgoing participants.

Screenshot 2024-09-30 at 5 29 18 pm

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🤦‍♂️🤦‍♂️🤦‍♂️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess at least b is expected since when you lock the phone the camera is interrupted in calls generally

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This happens straight away in the call, I didn't even press the lock button 😅

@stefanceriu
Copy link
Member Author

Superseded by #3372

@stefanceriu stefanceriu closed this Oct 7, 2024
@stefanceriu stefanceriu deleted the stefan/elementCallLockButtonPart2 branch October 7, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants