-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Knock a room - added a char counter for the message #3570
Knock a room - added a char counter for the message #3570
Conversation
Generated by 🚫 Danger Swift against 514cbea |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## develop #3570 +/- ##
===========================================
- Coverage 78.81% 78.81% -0.01%
===========================================
Files 757 757
Lines 63843 63850 +7
===========================================
Hits 50321 50321
- Misses 13522 13529 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3050e55
to
82a86b9
Compare
82a86b9
to
13458cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment on placement, otherwise lgtm 👍
ElementX/Sources/Screens/JoinRoomScreen/View/JoinRoomScreen.swift
Outdated
Show resolved
Hide resolved
|
No description provided.