Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knock a room - added a char counter for the message #3570

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Nov 29, 2024

No description provided.

@Velin92 Velin92 requested a review from a team as a code owner November 29, 2024 09:25
@Velin92 Velin92 requested review from stefanceriu and removed request for a team November 29, 2024 09:25
@Velin92 Velin92 added the pr-change for updates to an existing feature label Nov 29, 2024
Copy link

github-actions bot commented Nov 29, 2024

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 514cbea

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.81%. Comparing base (b808535) to head (514cbea).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...s/Screens/JoinRoomScreen/View/JoinRoomScreen.swift 70.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3570      +/-   ##
===========================================
- Coverage    78.81%   78.81%   -0.01%     
===========================================
  Files          757      757              
  Lines        63843    63850       +7     
===========================================
  Hits         50321    50321              
- Misses       13522    13529       +7     
Flag Coverage Δ
unittests 69.89% <70.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 force-pushed the mauroromito/add_char_counter_for_knock_message branch 3 times, most recently from 3050e55 to 82a86b9 Compare December 2, 2024 09:06
@Velin92 Velin92 force-pushed the mauroromito/add_char_counter_for_knock_message branch from 82a86b9 to 13458cb Compare December 2, 2024 16:12
@Velin92 Velin92 enabled auto-merge (squash) December 2, 2024 16:13
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment on placement, otherwise lgtm 👍

@Velin92 Velin92 disabled auto-merge December 2, 2024 16:28
@Velin92 Velin92 merged commit c7afde3 into develop Dec 2, 2024
5 checks passed
@Velin92 Velin92 deleted the mauroromito/add_char_counter_for_knock_message branch December 2, 2024 16:28
Copy link

sonarqubecloud bot commented Dec 2, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants