Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UI snapshots. #3585

Merged
merged 5 commits into from
Dec 4, 2024
Merged

Fix UI snapshots. #3585

merged 5 commits into from
Dec 4, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Dec 4, 2024 •
edited
Loading

#3581 changed the images we use in mocks but forgot to update the UI tests so this PR fixes that.

  • The first 2 commits remove snapshots from devices that don't match the names in the Fastfile. The tests will now crash when using the wrong device.
  • The next commit regenerates the snapshots. However, with our precision of 0.99, only 2 snapshots were deemed failures, therefore…
  • The final commit regenerates the snapshots with a precision set to 1.0. I didn't commit the change to precision though, only used it to trigger the update. It basically includes all the avatars, and some changes to text colours and the composer border colour.

UI tests run: https://github.com/element-hq/element-x-ios/actions/runs/12157954025

@pixlwave pixlwave requested a review from a team as a code owner December 4, 2024 10:16
@pixlwave pixlwave requested review from stefanceriu and removed request for a team December 4, 2024 10:16
@pixlwave pixlwave added the pr-build for changes related to build, tools, CI/CD label Dec 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024 •
edited
Loading

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 08b7c34

stefanceriu
stefanceriu approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@codecov Codecov
Copy link

codecov bot commented Dec 4, 2024 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
925 1 924 0
View the top 1 failed tests by shortest run time 
MediaUploadPreviewScreenViewModelTests testVideoUploadWithoutCaption()
Stack Traces | 11.4s run time 
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting publisher". (.../Sources/Extensions/XCTestCase.swift:43)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pixlwave pixlwave merged commit ab21520 into develop Dec 4, 2024
14 checks passed
@pixlwave pixlwave deleted the doug/ui-snapshots branch December 4, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanceriu stefanceriu stefanceriu approved these changes

Assignees
No one assigned
Labels
pr-build for changes related to build, tools, CI/CD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pixlwave @stefanceriu