Use TimelineMediaQuickLook in the MediaEventsTimelineScreen. #3598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixlwave
commented
Dec 10, 2024
| @@ -111,6 +111,21 @@ class TimelineMediaPreviewController: QLPreviewController, QLPreviewControllerDa | |||
|
|
|||
| present(detailsHostingController, animated: true) | |||
| } | |||
|
|
|||
| private var detailsButtonIcon: UIImage { | |||
| guard let bundle = Bundle(url: Bundle.main.bundleURL.appending(path: "CompoundDesignTokens_CompoundDesignTokens.bundle")) else { | |||
There was a problem hiding this comment.
Will add a proper method on the design tokens for this.
Generated by 🚫 Danger Swift against bf6406c |
Doesn't support swiping yet, just shows a single image.
pixlwave
force-pushed
the
doug/timeline-preview-ii
branch
from
22f8b0e to
1f13908
Compare
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
stefanceriu
added
the
pr-wip
stefanceriu
approved these changes
Dec 10, 2024
ElementX/Sources/Screens/FilePreviewScreen/TimelineMediaPreviewModels.swift
Show resolved
Hide resolved
ElementX/Sources/Screens/MediaEventsTimelineScreen/MediaEventsTimelineScreenViewModel.swift
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't support swiping yet, just shows a single image.
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-12-10.at.10.36.18.mp4