Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monthly media gallery separators #3601

Merged
merged 7 commits into from
Dec 11, 2024
Merged

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Dec 11, 2024

Add montly separators for the media gallery sections

  • change the separator timeline items so that they expose their timestamp instead of a formatted string
  • update related snapshots

This PR also fixes the order in which the tiles are presented, with the most recent one now appearing on the bottom right.

Screenshot 2024-12-11 at 10 11 38

@stefanceriu stefanceriu added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Dec 11, 2024
@stefanceriu stefanceriu requested a review from pixlwave December 11, 2024 08:16
@stefanceriu stefanceriu requested a review from a team as a code owner December 11, 2024 08:16
Copy link

github-actions bot commented Dec 11, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against a8f4c9f

Copy link

codecov bot commented Dec 11, 2024

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
881 3 878 0
View the top 1 failed tests by shortest run time
MediaUploadPreviewScreenViewModelTests testVideoUploadWithCaption()
Stack Traces | 12.9s run time
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting publisher". (.../Sources/Extensions/XCTestCase.swift:43)
View the full list of 2 ❄️ flaky tests
PreviewTests test_userProfileScreen()

Flake rate in main: 12.90% (Passed 108 times, Failed 16 times)

Stack Traces | 3.1s run time
failed - Snapshot "Verified User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_userProfileScreen-iPhone-16-en-GB.Verified-User.png"
@+
"file:.../tmp/PreviewTests/test_userProfileScreen-iPhone-16-en-GB.Verified-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9031372 is less than required 1.0
The lowest perceptual color precision 0.31062502 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:84)
PreviewTests test_joinRoomScreen()

Flake rate in main: 20.00% (Passed 40 times, Failed 10 times)

Stack Traces | 3.74s run time
failed - Snapshot "Unknown" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_joinRoomScreen-iPhone-16-en-GB.Unknown.png"
@+
"file:.../tmp/PreviewTests/test_joinRoomScreen-iPhone-16-en-GB.Unknown.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.966095 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:84)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@stefanceriu stefanceriu merged commit 0b85964 into develop Dec 11, 2024
13 checks passed
@stefanceriu stefanceriu deleted the stefan/mediaGallery-part2 branch December 11, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants