Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Tweaks #3606

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Design Tweaks #3606

merged 3 commits into from
Dec 11, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Dec 11, 2024

Changed the order of the room details actions to reflect the new designs (only for non DMs): https://www.figma.com/design/jvZ7TIyd7V9Vn8sIDB9vMd/Compound-iOS-Templates?node-id=1-21740&t=MoQwmxfuwp8OhLdz-0

  • removed the bloom bg from the join room screen
  • now DMs do not necessarily need to be encrypted rooms
  • changed bg of the knock banner

@Velin92 Velin92 requested a review from a team as a code owner December 11, 2024 16:58
@Velin92 Velin92 requested review from stefanceriu and pixlwave and removed request for a team December 11, 2024 16:58
Copy link

github-actions bot commented Dec 11, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 46f6c93

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I would still love to see the people row moved to the top of the list - it's basically always the thing I'm looking for when I come in here (and maybe in the future the media row), but this is already an improvement 👏

@Velin92 Velin92 added the pr-change for updates to an existing feature label Dec 11, 2024
also...
- removed the bloom bg from the join room screen
- now DMs do not necessarily need to be encrypted rooms
- changed bg of the knock banner
@Velin92 Velin92 force-pushed the mauroromito/december_design_tweaks branch from 27dd248 to 46f6c93 Compare December 11, 2024 17:20
@Velin92 Velin92 enabled auto-merge (squash) December 11, 2024 17:25
Copy link

codecov bot commented Dec 11, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
880 2 878 0
View the top 2 failed tests by shortest run time
PreviewTests test_timelineMediaPreviewDetailsView()
Stack Traces | 2.85s run time
failed - Snapshot "Image" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_timelineMediaPreviewDetailsView-iPhone-16-en-GB.Image.png"
@+
"file:.../tmp/PreviewTests/test_timelineMediaPreviewDetailsView-iPhone-16-en-GB.Image.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9968624 is less than required 1.0
The lowest perceptual color precision 0.29250002 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:84)
PreviewTests test_roomMembersListScreen()
Stack Traces | 11.5s run time
failed - Snapshot "Member" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_roomMembersListScreen-iPhone-16-en-GB.Member.png"
@+
"file:.../tmp/PreviewTests/test_roomMembersListScreen-iPhone-16-en-GB.Member.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.96676636 is less than required 1.0
The lowest perceptual color precision 0.148125 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:84)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@Velin92 Velin92 merged commit 89b9259 into develop Dec 11, 2024
13 checks passed
@Velin92 Velin92 deleted the mauroromito/december_design_tweaks branch December 11, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants