Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug where you're shown the remove caption action when it isn't available. #3608

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

pixlwave
Copy link
Member

I missed this when we re-ordered the action menu.

@pixlwave pixlwave requested a review from a team as a code owner December 11, 2024 18:50
@pixlwave pixlwave requested review from stefanceriu and removed request for a team December 11, 2024 18:50
@pixlwave pixlwave added the pr-bugfix for bug fix label Dec 11, 2024
Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 7cfae67

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.46%. Comparing base (89b9259) to head (7cfae67).
Report is 2 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3608      +/-   ##
===========================================
+ Coverage    78.44%   78.46%   +0.02%     
===========================================
  Files          770      770              
  Lines        65080    65080              
===========================================
+ Hits         51049    51066      +17     
+ Misses       14031    14014      -17     
Flag Coverage Δ
unittests 69.72% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stefanceriu stefanceriu merged commit 606eb0a into develop Dec 12, 2024
15 checks passed
@stefanceriu stefanceriu deleted the doug/fix-remove-caption-item branch December 12, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants