Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recently used emojis #3624

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Fix recently used emojis #3624

merged 4 commits into from
Dec 16, 2024

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Dec 16, 2024

3 bug fixes:

  • the recently used emojis stop working properly on 18.2 because of our usage of the private iOS preferences user defaults
  • the media gallery was sometimes showing the empty state at wrong times
  • video thumbnails were aspect fitting instead of filling and they weren't the right design

@stefanceriu stefanceriu added the pr-bugfix for bug fix label Dec 16, 2024
@stefanceriu stefanceriu requested a review from a team as a code owner December 16, 2024 10:10
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team December 16, 2024 10:10
Copy link

github-actions bot commented Dec 16, 2024

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against b2aa8a4

Copy link

codecov bot commented Dec 16, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
903 2 901 0
View the full list of 2 ❄️ flaky tests
PreviewTests test_timelineMediaPreviewDetailsView()

Flake rate in main: 25.00% (Passed 60 times, Failed 20 times)

Stack Traces | 1.71s run time
failed - Snapshot "Image" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_timelineMediaPreviewDetailsView-iPhone-16-en-GB.Image.png"
@+
"file:.../tmp/PreviewTests/test_timelineMediaPreviewDetailsView-iPhone-16-en-GB.Image.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9968624 is less than required 1.0
The lowest perceptual color precision 0.29250002 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:84)
PreviewTests test_roomMemberDetailsScreen()

Flake rate in main: 12.82% (Passed 68 times, Failed 10 times)

Stack Traces | 2.06s run time
failed - Snapshot "Verified User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-en-GB.Verified-User.png"
@+
"file:.../tmp/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-en-GB.Verified-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.848999 is less than required 1.0
The lowest perceptual color precision 0.0 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:84)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@stefanceriu stefanceriu force-pushed the stefan/bugFixes branch 4 times, most recently from 4705c90 to fc688fc Compare December 16, 2024 16:07
@stefanceriu stefanceriu merged commit 61ad718 into develop Dec 16, 2024
13 checks passed
@stefanceriu stefanceriu deleted the stefan/bugFixes branch December 16, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants