-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bottom Sheet to confirm DM creation #3739
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #3739 +/- ##
===========================================
+ Coverage 78.61% 78.62% +0.01%
===========================================
Files 791 792 +1
Lines 68430 68522 +92
===========================================
+ Hits 53795 53876 +81
- Misses 14635 14646 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but can we use the UserProfileProxy
instead please. It is due a refactor (userID
-> id
so it can be identifiable, drop the Proxy
suffix as it doesn't proxy anything etc) so feel free to do that if it helps.
ElementX/Sources/Screens/StartChatScreen/View/SendInviteConfirmationView.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/StartChatScreen/View/SendInviteConfirmationView.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/StartChatScreen/View/SendInviteConfirmationView.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/StartChatScreen/StartChatScreenModels.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/StartChatScreen/StartChatScreenViewModel.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the tweaks 👍
ElementX/Sources/Screens/RoomMemberDetailsScreen/RoomMemberDetailsScreenModels.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/UserProfileScreen/UserProfileScreenModels.swift
Outdated
Show resolved
Hide resolved
in the room member details
662eeab
to
c8709d3
Compare
|
Replacing the alert with a nice bottom sheet.
Also adding the confirmation, when selecting a user in the start chat screen.
fixes #3729
Simulator.Screen.Recording.-.iPhone.16.-.2025-02-04.at.23.46.07.mp4