Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom Sheet to confirm DM creation #3739

Merged
merged 6 commits into from
Feb 5, 2025

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Feb 4, 2025

Replacing the alert with a nice bottom sheet.
Also adding the confirmation, when selecting a user in the start chat screen.

fixes #3729

Simulator.Screen.Recording.-.iPhone.16.-.2025-02-04.at.23.46.07.mp4

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 65.48673% with 39 lines in your changes missing coverage. Please review.

Project coverage is 78.62%. Comparing base (42257a1) to head (c8709d3).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ens/StartChatScreen/StartChatScreenViewModel.swift 0.00% 13 Missing ⚠️
...rtChatScreen/View/SendInviteConfirmationView.swift 90.00% 7 Missing ⚠️
...erDetailsScreen/View/RoomMemberDetailsScreen.swift 16.66% 5 Missing ⚠️
...ens/UserProfileScreen/View/UserProfileScreen.swift 16.66% 5 Missing ⚠️
...Screens/StartChatScreen/View/StartChatScreen.swift 20.00% 4 Missing ⚠️
...UserProfileScreen/UserProfileScreenViewModel.swift 0.00% 3 Missing ⚠️
...tailsScreen/RoomMemberDetailsScreenViewModel.swift 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3739      +/-   ##
===========================================
+ Coverage    78.61%   78.62%   +0.01%     
===========================================
  Files          791      792       +1     
  Lines        68430    68522      +92     
===========================================
+ Hits         53795    53876      +81     
- Misses       14635    14646      +11     
Flag Coverage Δ
unittests 70.27% <65.48%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 added the pr-change for updates to an existing feature label Feb 4, 2025
@Velin92 Velin92 marked this pull request as ready for review February 4, 2025 22:39
@Velin92 Velin92 requested a review from a team as a code owner February 4, 2025 22:39
@Velin92 Velin92 requested review from pixlwave and removed request for a team February 4, 2025 22:39
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can we use the UserProfileProxy instead please. It is due a refactor (userID -> id so it can be identifiable, drop the Proxy suffix as it doesn't proxy anything etc) so feel free to do that if it helps.

@Velin92 Velin92 requested a review from pixlwave February 5, 2025 11:44
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the tweaks 👍

@Velin92 Velin92 force-pushed the mauroromito/confirm_dm_bottom_sheet branch from 662eeab to c8709d3 Compare February 5, 2025 12:07
@Velin92 Velin92 enabled auto-merge (squash) February 5, 2025 12:07
Copy link

sonarqubecloud bot commented Feb 5, 2025

@Velin92 Velin92 merged commit 921d1c6 into develop Feb 5, 2025
9 checks passed
@Velin92 Velin92 deleted the mauroromito/confirm_dm_bottom_sheet branch February 5, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Confirmation alert when creating a new DM
2 participants