Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update our development assets. #3783

Merged
merged 4 commits into from
Feb 11, 2025
Merged

Update our development assets. #3783

merged 4 commits into from
Feb 11, 2025

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Feb 11, 2025

Our development assets contained a mixture of original content, AI generated content and a handful of content found online. We had an enquiry about the license of these files and whilst they're not distributed with the final product they are in the repo, so this PR replaces all non-original content with original content. This means everything in the development assets directory can now be covered by the project's standard licences.

So long cat with sunglasses, you'll be missed 🫡

@pixlwave pixlwave requested a review from a team as a code owner February 11, 2025 09:42
@pixlwave pixlwave requested review from Velin92 and removed request for a team February 11, 2025 09:42
@pixlwave pixlwave added the pr-build for changes related to build, tools, CI/CD label Feb 11, 2025
Copy link

github-actions bot commented Feb 11, 2025

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against e755e76

Copy link

codecov bot commented Feb 11, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
978 1 977 0
View the full list of 1 ❄️ flaky tests
AppLockSetupUITests testCreateFlow()

Flake rate in main: 16.73% (Passed 209 times, Failed 42 times)

Stack Traces | 40.3s run time
failed - Snapshot "UI" does not match reference.

@−
"file:.../__Snapshots__/Application/appLockSetupFlow-3-iPhone-18-1-en-GB.UI.png"
@+
"file:.../__FailedScreenshots__/Application/appLockSetupFlow-3-iPhone-18-1-en-GB.UI.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9628906 is less than required 0.99
The lowest perceptual color precision 0.020624995 is less than required 0.98 (UITests/Sources/Application.swift:91)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@pixlwave pixlwave force-pushed the doug/development-assets branch from 77f37b7 to 0ea322f Compare February 11, 2025 10:13
@pixlwave pixlwave merged commit 8ee1427 into develop Feb 11, 2025
13 of 14 checks passed
@pixlwave pixlwave deleted the doug/development-assets branch February 11, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build for changes related to build, tools, CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants