Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename a couple of missed isEncryptedOneToOneRoom properties. #3804

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

pixlwave
Copy link
Member

This was taken care of as part of knocking and these properties are all set by roomProxy.isDirectOneToOneRoom, they just appear to have been missed from the refactor.

@pixlwave pixlwave requested a review from a team as a code owner February 18, 2025 15:52
@pixlwave pixlwave requested review from Velin92 and removed request for a team February 18, 2025 15:52
@pixlwave pixlwave added the pr-misc for other changes label Feb 18, 2025
Copy link

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 8225b70

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.78%. Comparing base (d8b88f1) to head (8225b70).
Report is 2 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...melineScreen/View/PinnedEventsTimelineScreen.swift 0.00% 1 Missing ⚠️
...X/Sources/Screens/RoomScreen/View/RoomScreen.swift 0.00% 1 Missing ⚠️
...entX/Sources/Screens/Timeline/TimelineModels.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3804      +/-   ##
===========================================
- Coverage    78.84%   78.78%   -0.06%     
===========================================
  Files          794      794              
  Lines        69616    69616              
===========================================
- Hits         54886    54846      -40     
- Misses       14730    14770      +40     
Flag Coverage Δ
unittests 70.61% <70.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit 3de025c into develop Feb 20, 2025
15 checks passed
@pixlwave pixlwave deleted the doug/rename-property branch February 20, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants