Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a couple of extra logs around the state of call ringing notifications. #3808

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

pixlwave
Copy link
Member

No description provided.

@pixlwave pixlwave requested a review from a team as a code owner February 20, 2025 14:17
@pixlwave pixlwave requested review from Velin92 and removed request for a team February 20, 2025 14:17
Copy link

github-actions bot commented Feb 20, 2025

Warnings
⚠️ Please provide a description for this PR.

Generated by 🚫 Danger Swift against 39b384c

@pixlwave pixlwave added the pr-misc for other changes label Feb 20, 2025
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.83%. Comparing base (d8b88f1) to head (39b384c).
Report is 4 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
NSE/Sources/NotificationServiceExtension.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3808      +/-   ##
===========================================
- Coverage    78.84%   78.83%   -0.01%     
===========================================
  Files          794      794              
  Lines        69616    69618       +2     
===========================================
  Hits         54886    54886              
- Misses       14730    14732       +2     
Flag Coverage Δ
unittests 70.62% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit b6b9f41 into develop Feb 24, 2025
15 checks passed
@pixlwave pixlwave deleted the doug/call-ringing-logs branch February 24, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants