Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render Room and Message Pills #3809

Merged
merged 17 commits into from
Feb 25, 2025

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Feb 20, 2025

Now is possible to generate pills in the timeline for

  • Any room permalink
  • Any room event permalink
  • Room addresses

fixes #2633

@Velin92 Velin92 added the pr-feature for a new feature label Feb 20, 2025
Copy link

codecov bot commented Feb 20, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
947 1 946 0
View the full list of 1 ❄️ flaky tests
PreviewTests test_roomMemberDetailsScreen()

Flake rate in main: 11.11% (Passed 16 times, Failed 2 times)

Stack Traces | 1.97s run time
failed - Snapshot "Ignored User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-en-GB.Ignored-User.png"
@+
"file:.../tmp/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-en-GB.Ignored-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.94610596 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:85)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link

github-actions bot commented Feb 21, 2025

Warnings
⚠️ This pull request seems relatively large. Please consider splitting it into multiple smaller ones.
⚠️ You seem to have made changes to views. Please consider adding screenshots.
⚠️

ElementX/Sources/Services/Client/ClientProxyProtocol.swift#L79 - TODOs should be resolved (This is a temporary value, in ...) (todo)

⚠️

ElementX/Sources/Services/Room/RoomPreview/RoomPreviewProxyProtocol.swift#L10 - A doc comment should be attached to a declaration (orphaned_doc_comment)

Generated by 🚫 Danger Swift against 6e8b187

@Velin92 Velin92 force-pushed the mauroromito/implement_room_and_message_pills branch from bc71abb to 0754a7b Compare February 21, 2025 19:57
@Velin92 Velin92 marked this pull request as ready for review February 21, 2025 19:57
@Velin92 Velin92 requested a review from a team as a code owner February 21, 2025 19:57
@Velin92 Velin92 requested review from pixlwave and removed request for a team February 21, 2025 19:57
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the new APIs in the JoinRoomScreen now too? i.e. to hide the publisher from #3817.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing a complete review and looks great to me! 👏

@Velin92
Copy link
Member Author

Velin92 commented Feb 25, 2025

Can we use the new APIs in the JoinRoomScreen now too? i.e. to hide the publisher from #3817.

we can't because that function is reactive subscription, while the API is just a check/get

@Velin92 Velin92 enabled auto-merge (squash) February 25, 2025 09:44
Copy link

@Velin92 Velin92 merged commit a2242c6 into develop Feb 25, 2025
8 checks passed
@Velin92 Velin92 deleted the mauroromito/implement_room_and_message_pills branch February 25, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Render permalinks in the timeline
3 participants