-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render Room and Message Pills #3809
Render Room and Message Pills #3809
Conversation
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
Generated by 🚫 Danger Swift against 6e8b187 |
bc71abb
to
0754a7b
Compare
ElementX/Sources/Screens/RoomScreen/RoomScreenCoordinator.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use the new APIs in the JoinRoomScreen now too? i.e. to hide the publisher from #3817.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing a complete review and looks great to me! 👏
ElementX/Sources/Screens/Timeline/View/TimelineItemViews/FormattedBodyText.swift
Show resolved
Hide resolved
we can't because that function is reactive subscription, while the API is just a check/get |
|
Now is possible to generate pills in the timeline for
fixes #2633