Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use alternative summary provider when listening to knocked membership change #3817

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Feb 24, 2025

Name says it all

@Velin92 Velin92 added the pr-bugfix for bug fix label Feb 24, 2025
@Velin92 Velin92 requested a review from a team as a code owner February 24, 2025 11:38
@Velin92 Velin92 requested review from pixlwave and removed request for a team February 24, 2025 11:38
@Velin92 Velin92 changed the title Use alternative summary provider when listening the knocked state change Use alternative summary provider when listening to knocked membership change Feb 24, 2025
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.83%. Comparing base (a01c519) to head (fbdf72c).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3817      +/-   ##
===========================================
- Coverage    78.83%   78.83%   -0.01%     
===========================================
  Files          794      794              
  Lines        69620    69620              
===========================================
- Hits         54884    54882       -2     
- Misses       14736    14738       +2     
Flag Coverage Δ
unittests 70.61% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 merged commit 9d5c4f7 into develop Feb 24, 2025
15 checks passed
@Velin92 Velin92 deleted the mauroromito/knocked_state_listener_fix branch February 24, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants