Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure diagnostics (and MapLibre) using Pkl. #3820

Merged
merged 6 commits into from
Feb 24, 2025
Merged

Conversation

pixlwave
Copy link
Member

Rather than using the secrets.xcconfig to inject values into the Info.plist, which was a very roundabout way to inject secrets, this PR uses our new favourite language Pkl to generate (with the help of SwiftGen) a Secrets enum directly in the app so that safe access is guaranteed at build time.
caveat: Safe for strings anyway, it could still crash at runtime when given a malformed URL.

Additionally this PR bumps the release version ready for tomorrow's RC.

@pixlwave pixlwave requested a review from a team as a code owner February 24, 2025 16:09
@pixlwave pixlwave requested review from Velin92 and removed request for a team February 24, 2025 16:09
@pixlwave pixlwave added the pr-build for changes related to build, tools, CI/CD label Feb 24, 2025
@pixlwave pixlwave changed the title Configure diagnostics (and maplibre) using Pkl. Configure diagnostics (and MapLibre) using Pkl. Feb 24, 2025
@@ -0,0 +1,19 @@
// swiftlint:disable all

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ Use 'next', 'this' or 'previous' instead to disable the 'all' rule once, or re-enable it as soon as possible (blanket_disable_command`)

Copy link

codecov bot commented Feb 24, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
932 1 931 0
View the full list of 1 ❄️ flaky tests
PreviewTests test_roomMemberDetailsScreen()

Flake rate in main: 16.67% (Passed 10 times, Failed 2 times)

Stack Traces | 2.53s run time
failed - Snapshot "Ignored User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-pseudo.Ignored-User.png"
@+
"file:.../tmp/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-pseudo.Ignored-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9442749 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:85)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@pixlwave pixlwave force-pushed the doug/diagnostics branch 2 times, most recently from bf27242 to 1413207 Compare February 24, 2025 17:54
@pixlwave pixlwave merged commit 6ded867 into develop Feb 24, 2025
8 checks passed
@pixlwave pixlwave deleted the doug/diagnostics branch February 24, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build for changes related to build, tools, CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants