-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure diagnostics (and MapLibre) using Pkl. #3820
Conversation
@@ -0,0 +1,19 @@ | |||
// swiftlint:disable all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Use 'next', 'this' or 'previous' instead to disable the 'all' rule once, or re-enable it as soon as possible(
blanket_disable_command`)
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
b0a7ca2
to
bea27eb
Compare
bf27242
to
1413207
Compare
1413207
to
1995634
Compare
|
Rather than using the secrets.xcconfig to inject values into the Info.plist, which was a very roundabout way to inject secrets, this PR uses our new favourite language Pkl to generate (with the help of SwiftGen) a Secrets enum directly in the app so that safe access is guaranteed at build time.
caveat: Safe for strings anyway, it could still crash at runtime when given a malformed URL.
Additionally this PR bumps the release version ready for tomorrow's RC.