Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the RustSDK to v25.2.25 #3823

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Bump the RustSDK to v25.2.25 #3823

merged 2 commits into from
Feb 25, 2025

Conversation

stefanceriu
Copy link
Member

.. and address breaking changes from matrix-org/matrix-rust-sdk/pull/4674

@stefanceriu stefanceriu added the pr-misc for other changes label Feb 25, 2025
@stefanceriu stefanceriu requested a review from a team as a code owner February 25, 2025 09:07
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team February 25, 2025 09:07
Copy link

github-actions bot commented Feb 25, 2025

Warnings
⚠️

ElementX/Sources/Services/Client/ClientProxyProtocol.swift#L79 - TODOs should be resolved (This is a temporary value, in ...) (todo)

Generated by 🚫 Danger Swift against 6db92ce

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.82%. Comparing base (6ded867) to head (6db92ce).
Report is 2 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
ElementX/Sources/Application/AppCoordinator.swift 0.00% 2 Missing ⚠️
...X/Sources/Services/Timeline/TimelineProvider.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3823   +/-   ##
========================================
  Coverage    78.81%   78.82%           
========================================
  Files          794      794           
  Lines        69615    69609    -6     
========================================
- Hits         54870    54867    -3     
+ Misses       14745    14742    -3     
Flag Coverage Δ
unittests 70.62% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stefanceriu stefanceriu merged commit 4f6c6f3 into develop Feb 25, 2025
6 checks passed
@stefanceriu stefanceriu deleted the stefan/sdkBump branch February 25, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants