Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project updates. #3837

Merged
merged 5 commits into from
Feb 26, 2025
Merged

Project updates. #3837

merged 5 commits into from
Feb 26, 2025

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Feb 26, 2025

The PR makes the following changes:

  • Stop using the AppIdentifierPrefix build var as it isn't compatible with re-signing.
    • Instead we can use DEVELOPMENT_TEAM which works if you know who's going to re-sign before you build.
  • Manage the .entitlements files using XcodeGen like with do with the Info.plists.
  • Remove the old NCE extension as its configuration hasn't been kept up to date with project changes (and the implementation was empty).

@pixlwave pixlwave added the pr-build for changes related to build, tools, CI/CD label Feb 26, 2025
@pixlwave pixlwave requested a review from a team as a code owner February 26, 2025 17:09
@pixlwave pixlwave requested review from stefanceriu and removed request for a team February 26, 2025 17:09
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.98%. Comparing base (5b2f6cf) to head (a286086).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3837      +/-   ##
===========================================
- Coverage    78.98%   78.98%   -0.01%     
===========================================
  Files          794      794              
  Lines        70190    70190              
===========================================
- Hits         55442    55439       -3     
- Misses       14748    14751       +3     
Flag Coverage Δ
unittests 70.87% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave enabled auto-merge (squash) February 26, 2025 18:14
@pixlwave pixlwave merged commit b01070c into develop Feb 26, 2025
8 checks passed
@pixlwave pixlwave deleted the doug/pipeline branch February 26, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build for changes related to build, tools, CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants