Join room by address #3840
Merged
Join room by address #3840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #3840 +/- ##
===========================================
+ Coverage 78.99% 79.01% +0.01%
===========================================
Files 794 796 +2
Lines 70215 70584 +369
===========================================
+ Hits 55467 55771 +304
- Misses 14748 14813 +65
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Velin92
force-pushed
the
mauroromito/join_room_by_alias
branch
from
870f121 to
7a5e6c0
Compare
pixlwave
approved these changes
Feb 28, 2025
ElementX/Sources/Screens/Authentication/AuthenticationTextFieldStyle.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/Authentication/AuthenticationTextFieldStyle.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/StartChatScreen/StartChatScreenViewModel.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/Authentication/AuthenticationTextFieldStyle.swift
Outdated
Show resolved
Hide resolved
PreviewTests/Sources/__Snapshots__/PreviewTests/test_serverSelection-iPad-en-GB.3.png
Outdated
Show resolved
Hide resolved
PreviewTests/Sources/__Snapshots__/PreviewTests/test_startChatScreen-iPhone-16-en-GB.1.png
Outdated
Show resolved
Hide resolved
Velin92
force-pushed
the
mauroromito/join_room_by_alias
branch
from
b68d6a5 to
96e484e
Compare
- moving the file - changing the name of the action - reintroduce the debounce text queries - add comments
updated tests
Velin92
force-pushed
the
mauroromito/join_room_by_alias
branch
from
96e484e to
84bf3b8
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3807
fixes #3842
This also includes
Simulator.Screen.Recording.-.iPhone.16.-.2025-02-27.at.19.50.08.mp4