Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show room encryption state in the composer #3841

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

stefanceriu
Copy link
Member

  • shows an encryption icon next to the composer
  • changes the placeholder text base based on it
  • converges on same placeholder for both composers

@stefanceriu stefanceriu requested a review from a team as a code owner February 27, 2025 08:19
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team February 27, 2025 08:19
Copy link

github-actions bot commented Feb 27, 2025

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 88d2d55

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 97.87234% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.99%. Comparing base (5b2f6cf) to head (88d2d55).
Report is 4 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...mScreen/ComposerToolbar/View/MessageComposer.swift 96.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3841   +/-   ##
========================================
  Coverage    78.98%   78.99%           
========================================
  Files          794      794           
  Lines        70190    70222   +32     
========================================
+ Hits         55442    55474   +32     
  Misses       14748    14748           
Flag Coverage Δ
unittests 70.87% <97.87%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu added the pr-feature for a new feature label Feb 27, 2025
@stefanceriu stefanceriu merged commit 8906875 into develop Feb 27, 2025
15 checks passed
@stefanceriu stefanceriu deleted the stefan/messageComposerEncryptionBadge branch February 27, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants