Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set APP_GROUP_IDENTIFIER directly. #3847

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Set APP_GROUP_IDENTIFIER directly. #3847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ElementX.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8092,10 +8092,9 @@
buildSettings = {
ALWAYS_SEARCH_USER_PATHS = NO;
APP_DISPLAY_NAME = "Element X";
APP_GROUP_IDENTIFIER = "group.$(BASE_APP_GROUP_IDENTIFIER)";
APP_GROUP_IDENTIFIER = group.io.element;
APP_NAME = ElementX;
ASSETCATALOG_COMPILER_GLOBAL_ACCENT_COLOR_NAME = "colors/accent-color";
BASE_APP_GROUP_IDENTIFIER = io.element;
BASE_BUNDLE_IDENTIFIER = io.element.elementx;
CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
CLANG_ANALYZER_NONNULL = YES;
Expand Down Expand Up @@ -8163,10 +8162,9 @@
buildSettings = {
ALWAYS_SEARCH_USER_PATHS = NO;
APP_DISPLAY_NAME = "Element X";
APP_GROUP_IDENTIFIER = "group.$(BASE_APP_GROUP_IDENTIFIER)";
APP_GROUP_IDENTIFIER = group.io.element;
APP_NAME = ElementX;
ASSETCATALOG_COMPILER_GLOBAL_ACCENT_COLOR_NAME = "colors/accent-color";
BASE_APP_GROUP_IDENTIFIER = io.element;
BASE_BUNDLE_IDENTIFIER = io.element.elementx;
CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
CLANG_ANALYZER_NONNULL = YES;
Expand Down
2 changes: 1 addition & 1 deletion Enterprise
Open in desktop
Submodule Enterprise updated from 86e0ea to 23bc91
2 changes: 1 addition & 1 deletion Variants/Alpha/alpha.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
settings:
BASE_APP_GROUP_IDENTIFIER: io.element.pr
APP_GROUP_IDENTIFIER: group.io.element.pr
BASE_BUNDLE_IDENTIFIER: io.element.elementx.pr

targets:
Expand Down
2 changes: 1 addition & 1 deletion Variants/Nightly/nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
settings:
BASE_APP_GROUP_IDENTIFIER: io.element.nightly
APP_GROUP_IDENTIFIER: group.io.element.nightly
BASE_BUNDLE_IDENTIFIER: io.element.elementx.nightly

targets:
Expand Down
2 changes: 1 addition & 1 deletion app.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
settings:
APP_DISPLAY_NAME: Element X
PRODUCTION_APP_NAME: Element
BASE_APP_GROUP_IDENTIFIER: io.element
APP_GROUP_IDENTIFIER: group.io.element
BASE_BUNDLE_IDENTIFIER: io.element.elementx
ASSETCATALOG_COMPILER_GLOBAL_ACCENT_COLOR_NAME: "colors/accent-color"
DEVELOPMENT_TEAM: 7J4U792NQT
1 change: 0 additions & 1 deletion project.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ options:
settings:
CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED: true
ENABLE_BITCODE: false
APP_GROUP_IDENTIFIER: group.$(BASE_APP_GROUP_IDENTIFIER)
APP_NAME: ElementX
KEYCHAIN_ACCESS_GROUP_IDENTIFIER: "$(DEVELOPMENT_TEAM).$(BASE_BUNDLE_IDENTIFIER)"
MARKETING_VERSION: 25.03.2
Expand Down
Loading