Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private rooms should have .invited history visibility #3850

Closed
wants to merge 2 commits into from

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Feb 27, 2025

fixes #3843

We want to always have private rooms to always start their room history with the .invited override

@Velin92 Velin92 added the pr-bugfix for bug fix label Feb 27, 2025
@Velin92 Velin92 requested a review from a team as a code owner February 27, 2025 20:13
@Velin92 Velin92 requested review from stefanceriu and removed request for a team February 27, 2025 20:13
@Velin92 Velin92 changed the title Private rooms have .invited history visibility Private rooms should have .invited history visibility Feb 27, 2025
Copy link

github-actions bot commented Feb 27, 2025

Warnings
⚠️ Please provide a description for this PR.

Generated by 🚫 Danger Swift against fd1849e

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.96%. Comparing base (8906875) to head (fd1849e).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3850   +/-   ##
========================================
  Coverage    78.95%   78.96%           
========================================
  Files          794      794           
  Lines        70221    70221           
========================================
+ Hits         55445    55449    +4     
+ Misses       14776    14772    -4     
Flag Coverage Δ
unittests 70.83% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but can you expand the PR to describe why this is necessary and what used to happen before?

Can you also link the relevant ticket and rust PR?

Also please make sure you change the commit title from bugfix before you merge this (presumably you wanted to squash merge it and change it at that point)

Ideally all of this should've been done before sending it off to review to help the reviewer get better context.

@Velin92 Velin92 closed this Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Set history visibility to "invited" when creating private room
2 participants