Private rooms are now created with the .invited room history visibility
#3853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Velin92
requested review from
pixlwave and
stefanceriu
and removed request for
a team
Velin92
force-pushed
the
mauroromito/update_create_room_parameters_2
branch
from
8135234 to
e577f60
Compare
Velin92
changed the title
.default room history visibility.invited room history visibility
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #3853 +/- ##
===========================================
- Coverage 78.96% 78.96% -0.01%
===========================================
Files 794 794
Lines 70215 70215
===========================================
- Hits 55445 55443 -2
- Misses 14770 14772 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pixlwave
approved these changes
Feb 28, 2025
the since selection option (or .shared) |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3843
We want to always have private rooms to always start their room history with the .invited override