-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show "Room" for unresolved event permalinks #3854
show "Room" for unresolved event permalinks #3854
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌
Checked with @Anderas and we want to have the same behaviour of EW, so... we apply the generic "Room" string only for event permalinks, room permalinks are already consistent with EW by showing the room ID |
Makes sense 👍 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #3854 +/- ##
========================================
Coverage 78.95% 78.96%
========================================
Files 794 794
Lines 70221 70215 -6
========================================
- Hits 55445 55442 -3
+ Misses 14776 14773 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This is the same behaviour of EW, that we want to have in EX for event permalinks