Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show "Room" for unresolved event permalinks #3854

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Feb 28, 2025

This is the same behaviour of EW, that we want to have in EX for event permalinks

@Velin92 Velin92 added the pr-bugfix for bug fix label Feb 28, 2025
@Velin92 Velin92 requested a review from a team as a code owner February 28, 2025 10:32
@Velin92 Velin92 requested review from stefanceriu and removed request for a team February 28, 2025 10:32
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@Velin92 Velin92 enabled auto-merge (rebase) February 28, 2025 10:40
@pixlwave
Copy link
Member

Just to double check, do we just want to do this for events? I.e. should we also do the same for the roomID case?
Screenshot 2025-02-28 at 10 39 16 am

@Velin92 Velin92 disabled auto-merge February 28, 2025 10:41
@Velin92
Copy link
Member Author

Velin92 commented Feb 28, 2025

Just to double check, do we just want to do this for events? I.e. should we also do the same for the roomID case? Screenshot 2025-02-28 at 10 39 16 am

Checked with @Anderas and we want to have the same behaviour of EW, so... we apply the generic "Room" string only for event permalinks, room permalinks are already consistent with EW by showing the room ID

@Velin92 Velin92 enabled auto-merge (rebase) February 28, 2025 10:42
@pixlwave
Copy link
Member

Makes sense 👍

@Velin92 Velin92 merged commit 14fa7d8 into develop Feb 28, 2025
10 checks passed
@Velin92 Velin92 deleted the mauroromito/event_pills_hide_unresolved_room_value branch February 28, 2025 10:53
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.96%. Comparing base (8906875) to head (7d2fc8f).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3854   +/-   ##
========================================
  Coverage    78.95%   78.96%           
========================================
  Files          794      794           
  Lines        70221    70215    -6     
========================================
- Hits         55445    55442    -3     
+ Misses       14776    14773    -3     
Flag Coverage Δ
unittests 70.85% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants