-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a static room summary provider to resolve room summaries through id and aliases #3863
Conversation
is missing even if it appears in the room list
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #3863 +/- ##
===========================================
- Coverage 79.03% 79.02% -0.01%
===========================================
Files 796 796
Lines 70584 70599 +15
===========================================
+ Hits 55786 55793 +7
- Misses 14798 14806 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
We figured it out - using the forwarding screen or global search leaves the alternate provider in a filtered state. |
Generated by 🚫 Danger Swift against c1029e6 |
since using the sop function is safer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, lgtm 👍
|
This fixes two issues:
alternateRoomSummaryProvider
when we are done with it to avoid the various views to clash with each othersstaticRoomSummaryProvider
to which we can't update its filtering through the protocol making its usage just for the sake of finding a specific in the room list, independent of the filtering or query state, also we set a max page size of.max
over itfixes #3852