Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show a badge in the composer if the room is unencrypted. #3866

Merged
merged 3 commits into from
Mar 4, 2025

Conversation

stefanceriu
Copy link
Member

Partially reverts the previous change where we were showing different badges for encrypted/unencrypted. See snapshots for changes.

@stefanceriu stefanceriu requested a review from a team as a code owner March 4, 2025 12:38
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team March 4, 2025 12:38
Copy link

github-actions bot commented Mar 4, 2025

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against d46d442

Copy link

sonarqubecloud bot commented Mar 4, 2025

@stefanceriu stefanceriu added pr-misc for other changes pr-feature for a new feature and removed pr-misc for other changes labels Mar 4, 2025
@stefanceriu stefanceriu enabled auto-merge (squash) March 4, 2025 12:45
Copy link

codecov bot commented Mar 4, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
951 1 950 0
View the full list of 1 ❄️ flaky tests
PreviewTests test_roomMemberDetailsScreen()

Flake rate in main: 7.69% (Passed 48 times, Failed 4 times)

Stack Traces | 1.8s run time
failed - Snapshot "Ignored User" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-en-GB.Ignored-User.png"
@+
"file:.../tmp/PreviewTests/test_roomMemberDetailsScreen-iPhone-16-en-GB.Ignored-User.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.94610596 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:85)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@stefanceriu stefanceriu disabled auto-merge March 4, 2025 12:58
@stefanceriu stefanceriu merged commit 56d8af1 into develop Mar 4, 2025
16 checks passed
@stefanceriu stefanceriu deleted the stefan/composerEncryptionBadgePartialRevert branch March 4, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants