-
Notifications
You must be signed in to change notification settings - Fork 151
Various timeline code improvements #4144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e) to hold all the timeline specific bindings that are currently duplicated throughout the screens a timeline is used.
Generated by 🚫 Danger Swift against 0d38543 |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #4144 +/- ##
===========================================
- Coverage 79.36% 79.21% -0.16%
===========================================
Files 813 814 +1
Lines 74426 74593 +167
===========================================
+ Hits 59071 59091 +20
- Misses 15355 15502 +147
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice refactor, thank you for the tidy-up and for adding the docs!
ElementX/Sources/Services/Timeline/TimelineController/TimelineControllerProtocol.swift
Outdated
Show resolved
Hide resolved
… with room timelines.
2d3dfb6
to
0d38543
Compare
|
This patch introduces a new SwiftUI TimelineView layer (wrapping the representable) to hold all the timeline specific bindings that are currently duplicated throughout the screens a timeline is used. It also renames the
TimelineProvider
toTimelineItemProvider
and adds more documentation.