Skip to content

Various timeline code improvements #4144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2025
Merged

Conversation

stefanceriu
Copy link
Member

This patch introduces a new SwiftUI TimelineView layer (wrapping the representable) to hold all the timeline specific bindings that are currently duplicated throughout the screens a timeline is used. It also renames the TimelineProvider to TimelineItemProvider and adds more documentation.

…e) to hold all the timeline specific bindings that are currently duplicated throughout the screens a timeline is used.
@stefanceriu stefanceriu requested a review from a team as a code owner May 23, 2025 07:30
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team May 23, 2025 07:30
@stefanceriu stefanceriu added the pr-misc for other changes label May 23, 2025
Copy link

github-actions bot commented May 23, 2025

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 0d38543

Copy link

codecov bot commented May 23, 2025

Codecov Report

Attention: Patch coverage is 45.65217% with 50 lines in your changes missing coverage. Please review.

Project coverage is 79.21%. Comparing base (250a7ed) to head (0d38543).
Report is 4 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...X/Sources/Screens/Timeline/View/TimelineView.swift 36.84% 24 Missing ⚠️
...meline/TimelineController/TimelineController.swift 0.00% 16 Missing ⚠️
...RoomDetailsScreen/RoomDetailsScreenViewModel.swift 37.50% 5 Missing ⚠️
.../Sources/Other/NetworkMonitor/NetworkMonitor.swift 0.00% 1 Missing ⚠️
...melineScreen/View/PinnedEventsTimelineScreen.swift 0.00% 1 Missing ⚠️
...readTimelineScreen/View/ThreadTimelineScreen.swift 0.00% 1 Missing ⚠️
...ervices/Room/RoomSummary/RoomSummaryProvider.swift 0.00% 1 Missing ⚠️
...urces/Services/Timeline/TimelineItemProvider.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4144      +/-   ##
===========================================
- Coverage    79.36%   79.21%   -0.16%     
===========================================
  Files          813      814       +1     
  Lines        74426    74593     +167     
===========================================
+ Hits         59071    59091      +20     
- Misses       15355    15502     +147     
Flag Coverage Δ
unittests 71.54% <45.65%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice refactor, thank you for the tidy-up and for adding the docs!

@stefanceriu stefanceriu force-pushed the stefan/timelineImprovements branch from 2d3dfb6 to 0d38543 Compare May 23, 2025 13:07
@stefanceriu stefanceriu merged commit 29cfcb0 into develop May 23, 2025
5 checks passed
@stefanceriu stefanceriu deleted the stefan/timelineImprovements branch May 23, 2025 13:08
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants