Skip to content

Fix a couple of crashes on macOS from a missing environment object. #4153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

pixlwave
Copy link
Member

This fixes a regression introduced in #4144 where we assumed that if it works on iOS it will work on macOS 🫠

@pixlwave pixlwave requested a review from a team as a code owner May 28, 2025 09:03
@pixlwave pixlwave requested review from stefanceriu and removed request for a team May 28, 2025 09:03
@pixlwave pixlwave added the pr-bugfix for bug fix label May 28, 2025
Copy link

Copy link

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 4545ede

Copy link

codecov bot commented May 28, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.38%. Comparing base (9a9bdcb) to head (4545ede).
Report is 2 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...X/Sources/Screens/Timeline/View/TimelineView.swift 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4153      +/-   ##
===========================================
- Coverage    79.41%   79.38%   -0.04%     
===========================================
  Files          813      813              
  Lines        74408    74411       +3     
===========================================
- Hits         59089    59069      -20     
- Misses       15319    15342      +23     
Flag Coverage Δ
unittests 71.49% <66.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit 8a1a0ce into develop May 28, 2025
14 of 15 checks passed
@pixlwave pixlwave deleted the doug/mac-environment branch May 28, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants