Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add background job to clear unreferenced state groups #18154

Open
wants to merge 45 commits into
base: develop
Choose a base branch
from
Open

Add background job to clear unreferenced state groups #18154

wants to merge 45 commits into from
+376 −74

Conversation

devonh
Copy link
Member

@devonh devonh commented Feb 12, 2025 •
edited
Loading

Fixes #18150

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@devonh
Copy link
Member Author

devonh commented Feb 12, 2025

I still need to add tests, but otherwise this is currently working.

@devonh devonh marked this pull request as ready for review February 12, 2025 23:31
@devonh devonh requested a review from a team as a code owner February 12, 2025 23:31
erikjohnston
erikjohnston reviewed Feb 13, 2025
View reviewed changes
@github-actions github-actions bot deployed to PR Documentation Preview February 13, 2025 22:06 Active
@devonh devonh requested a review from erikjohnston February 13, 2025 22:10
@github-actions github-actions bot deployed to PR Documentation Preview February 13, 2025 22:10 Active
@github-actions github-actions bot deployed to PR Documentation Preview February 13, 2025 23:38 Active
@github-actions github-actions bot deployed to PR Documentation Preview February 14, 2025 00:11 Active
@github-actions github-actions bot deployed to PR Documentation Preview February 14, 2025 00:18 Active
@github-actions github-actions bot deployed to PR Documentation Preview February 19, 2025 00:07 Active
@github-actions github-actions bot deployed to PR Documentation Preview February 19, 2025 00:10 Active
@github-actions github-actions bot deployed to PR Documentation Preview February 19, 2025 00:31 Active
@github-actions github-actions bot deployed to PR Documentation Preview February 19, 2025 00:53 Active
@devonh devonh requested a review from erikjohnston February 19, 2025 01:09
@github-actions github-actions bot deployed to PR Documentation Preview February 19, 2025 19:27 Active
@github-actions github-actions bot deployed to PR Documentation Preview February 19, 2025 20:48 Active
@github-actions github-actions bot deployed to PR Documentation Preview February 19, 2025 20:55 Active
@github-actions github-actions bot deployed to PR Documentation Preview February 19, 2025 21:05 Active
@github-actions github-actions bot deployed to PR Documentation Preview February 19, 2025 21:13 Active
erikjohnston
erikjohnston reviewed Feb 24, 2025
View reviewed changes
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor tweaks, otherwise I think the approach is good

@devonh @erikjohnston
Update synapse/_scripts/synapse_port_db.py
89ec2a3 
Co-authored-by: Erik Johnston <erikj@element.io>
@github-actions github-actions bot deployed to PR Documentation Preview February 24, 2025 17:47 Active
@devonh
Copy link
Member Author

devonh commented Feb 24, 2025

Should be good to go now!

@devonh devonh requested a review from erikjohnston February 24, 2025 20:56
@github-actions github-actions bot deployed to PR Documentation Preview February 24, 2025 20:57 Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadLittleMods MadLittleMods MadLittleMods left review comments

@MatMaul MatMaul MatMaul left review comments

@erikjohnston erikjohnston Awaiting requested review from erikjohnston

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add background job to clear unreferenced state groups
4 participants
@devonh @MadLittleMods @MatMaul @erikjohnston