Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated worker configurations in worker-bash-script #18126

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Remove deprecated worker configurations in worker-bash-script #18126

wants to merge 2 commits into from

Conversation

qashlan
Copy link
Contributor

@qashlan qashlan commented Feb 3, 2025

When running the worker generation script app crash for deprecated configurations

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@qashlan
remove depricated worker configration in worker-bash-script
e3f009e 
Signed-off-by: Ahmed Qashlan <ahmedelqashlan@gmail.com>
@qashlan
add change log
1e1ddc4 
Signed-off-by: Ahmed Qashlan <ahmedelqashlan@gmail.com>
@qashlan qashlan force-pushed the depricated-worker-configs branch from 57d9125 to 1e1ddc4 Compare February 3, 2025 01:14
@qashlan qashlan marked this pull request as ready for review February 3, 2025 01:14
@qashlan qashlan requested a review from a team as a code owner February 3, 2025 01:14
sandhose
sandhose reviewed Feb 19, 2025
View reviewed changes
contrib/workers-bash-scripts/create-multiple-generic-workers.md
@@ -11,10 +11,6 @@ cat << EOF > generic_worker$i.yaml
worker_app: synapse.app.generic_worker
worker_name: generic_worker$i

# The replication listener on the main synapse process.
worker_replication_host: 127.0.0.1
worker_replication_http_port: 9093
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the upgrade docs from when we removed this option, looks like the main worker needs to be added to the instance_map as well. Could you also do that?

https://github.com/element-hq/synapse/blob/1525a3b4d48a0f5657d61423e1f205bff9a77948/docs/upgrade.md#upgrading-to-v1840

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandhose sandhose sandhose left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qashlan @sandhose