Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to limit key queries to users sharing rooms as per MSC4263 #18180

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add option to limit key queries to users sharing rooms as per MSC4263 #18180

wants to merge 2 commits into from

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Feb 20, 2025 •
edited
Loading

This implements matrix-org/matrix-spec-proposals#4263.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@Johennes
Add option to limit key queries to users sharing rooms as per MSC4263
26f0d74 
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
@github-actions github-actions bot deployed to PR Documentation Preview February 20, 2025 11:33 Active
@Johennes Johennes mentioned this pull request Feb 20, 2025
Open
@github-actions github-actions bot deployed to PR Documentation Preview February 20, 2025 11:36 Active
@Johennes Johennes mentioned this pull request Feb 20, 2025
Open
@Johennes Johennes marked this pull request as ready for review February 20, 2025 12:16
@Johennes Johennes requested a review from a team as a code owner February 20, 2025 12:16
Johennes
Johennes commented Feb 21, 2025
View reviewed changes
synapse/handlers/e2e_keys.py

# Strip invalid user IDs and user IDs the requesting user does not share rooms with.
result: Dict[str, List[str]] = {}
from_rooms = await self.store.get_rooms_for_user(from_user_id)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this doesn't include invited rooms which I think would be required. There seems to be no existing method for this on the store though. I suppose I can just add one, copying the get_rooms_for_user implementation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Johennes