Pin: Fix issue in json parse error handling

Previously, we had a fix that better handled a json parse error in the
response body.  It turns out there was more than one place a parse was
happening and we just hit the 2nd place.  Now we handle
JSON::ParserError in all the places.

Author: duff

lib/active_merchant/billing/gateways/pin.rb

@@ -152,15 +152,16 @@ def commit(method, action, params, options)
           body = parse(raw_response)
         rescue ResponseError => e
           body = parse(e.response.body)
-        rescue JSON::ParserError
-          return unparsable_response(raw_response)
         end
 
         if body["response"]
           success_response(body)
         elsif body["error"]
           error_response(body)
         end
+
+      rescue JSON::ParserError
+        return unparsable_response(raw_response)
       end
 
       def success_response(body)

test/unit/gateways/pin_test.rb

@@ -84,8 +84,16 @@ def test_unsuccessful_request
     assert response.test?
   end
 
-  def test_unparsable_response
-    @gateway.expects(:ssl_request).returns("This is not [ JSON")
+  def test_unparsable_body_of_successful_response
+    @gateway.stubs(:raw_ssl_request).returns(MockResponse.succeeded("This is not [ JSON"))
+
+    assert response = @gateway.purchase(@amount, @credit_card, @options)
+    assert_failure response
+    assert_match(/Invalid JSON response received/, response.message)
+  end
+
+  def test_unparsable_body_of_failed_response
+    @gateway.stubs(:raw_ssl_request).returns(MockResponse.failed("This is not [ JSON"))
 
     assert response = @gateway.purchase(@amount, @credit_card, @options)
     assert_failure response
@@ -488,4 +496,19 @@ def successful_capture_response
       }
     }'
   end
+
+  class MockResponse
+    attr_reader :code, :body
+    def self.succeeded(body)
+      MockResponse.new(200, body)
+    end
+
+    def self.failed(body)
+      MockResponse.new(422, body)
+    end
+
+    def initialize(code, body)
+      @code, @body = code, body
+    end
+  end
 end