Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: intrinsic abort types #1212

Merged
merged 1 commit into from
Feb 16, 2025
Merged

feat: intrinsic abort types #1212

merged 1 commit into from
Feb 16, 2025

Conversation

sgammon
Copy link
Member

@sgammon sgammon commented Feb 16, 2025

Ready for review Powered by Pull Request Badge

Summary

Adds native implementations of AbortController and AbortSignal.

  • feat: implement AbortController
  • feat: implement AbortSignal
    • Implement EventTarget
  • chore: remove abort types from polyfills.js

@sgammon sgammon added feature Large PRs or issues with full-blown features 🚧 WIP Works-in-progress. Blocks merge lang:javascript Issues relating to JavaScript api:node Node API and stdlib labels Feb 16, 2025
@sgammon sgammon added this to the Release R7: Beta 1 milestone Feb 16, 2025
@sgammon sgammon self-assigned this Feb 16, 2025
@sgammon sgammon force-pushed the feat/intrinsic-abort branch 2 times, most recently from 929313a to 8b76b16 Compare February 16, 2025 00:07
Copy link

codecov bot commented Feb 16, 2025

Codecov Report

Attention: Patch coverage is 94.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 53.15%. Comparing base (9bd1849) to head (ca39c98).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...e/gvm/internals/intrinsics/js/abort/AbortSignal.kt 90.76% 2 Missing and 4 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1212      +/-   ##
==========================================
+ Coverage   52.89%   53.15%   +0.26%     
==========================================
  Files         425      429       +4     
  Lines       17142    17236      +94     
  Branches     3101     3122      +21     
==========================================
+ Hits         9067     9162      +95     
+ Misses       7062     7055       -7     
- Partials     1013     1019       +6     
Flag Coverage Δ
jvm 53.15% <94.00%> (+0.26%) ⬆️
lib 53.15% <94.00%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...gvm/internals/intrinsics/js/AbstractJsIntrinsic.kt 80.00% <100.00%> (-20.00%) ⬇️
...m/internals/intrinsics/js/abort/AbortController.kt 100.00% <100.00%> (ø)
...m/internals/intrinsics/js/abort/AbortIntrinsics.kt 100.00% <100.00%> (ø)
.../kotlin/elide/runtime/gvm/internals/js/JsTimers.kt 60.99% <100.00%> (ø)
...vm/src/main/kotlin/elide/runtime/gvm/js/JsError.kt 32.60% <100.00%> (+2.17%) ⬆️
.../kotlin/elide/runtime/intrinsics/GuestIntrinsic.kt 28.57% <ø> (ø)
...lin/elide/runtime/intrinsics/js/AbortController.kt 100.00% <100.00%> (ø)
...tlin/elide/runtime/intrinsics/js/ReadableStream.kt 0.00% <ø> (ø)
...tlin/elide/runtime/intrinsics/js/node/EventsAPI.kt 100.00% <ø> (ø)
.../runtime/intrinsics/js/node/events/EventOptions.kt 29.03% <ø> (ø)
... and 6 more

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bd1849...ca39c98. Read the comment docs.

@sgammon sgammon force-pushed the feat/intrinsic-abort branch from 8b76b16 to 7edc86a Compare February 16, 2025 00:44
@sgammon sgammon marked this pull request as ready for review February 16, 2025 00:45
@sgammon sgammon force-pushed the feat/intrinsic-abort branch from 7edc86a to 8b5d4e5 Compare February 16, 2025 00:45
@sgammon sgammon force-pushed the feat/intrinsic-abort branch from 8b5d4e5 to 4345944 Compare February 16, 2025 02:46
@sgammon sgammon removed the 🚧 WIP Works-in-progress. Blocks merge label Feb 16, 2025
@sgammon sgammon requested a review from a team February 16, 2025 02:52
- feat(graalvm): implement intrinsic `AbortController`
- feat(graalvm): implement intrinsic `AbortSignal`
- test: add test for js globals
- chore: eliminate `polyfills.js` from bootstrap steps

Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon sgammon force-pushed the feat/intrinsic-abort branch from 4345944 to ca39c98 Compare February 16, 2025 06:34
@sgammon sgammon linked an issue Feb 16, 2025 that may be closed by this pull request
@sgammon sgammon merged commit 5d4cfa4 into main Feb 16, 2025
21 checks passed
@sgammon sgammon deleted the feat/intrinsic-abort branch February 16, 2025 07:34
@sgammon sgammon mentioned this pull request Feb 17, 2025
20 tasks
@sgammon sgammon mentioned this pull request Mar 11, 2025
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api:node Node API and stdlib feature Large PRs or issues with full-blown features lang:javascript Issues relating to JavaScript
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

JS API: Abort Controller/Abort Signal
2 participants