Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add polyfilled fetch support #1229

Merged
merged 1 commit into from
Feb 23, 2025
Merged

feat: add polyfilled fetch support #1229

merged 1 commit into from
Feb 23, 2025

Conversation

sgammon
Copy link
Member

@sgammon sgammon commented Feb 23, 2025

Ready for review Powered by Pull Request Badge

Summary

Adds polyfilled support for the Fetch API (#1218).

  • feat: add fetch polyfill to runtime
  • fix: allow class lookup from guest context
  • chore: rebuild js runtime modules

Changelog

feat(runtime): add polyfill for `fetch` api
chore(graalvm): rebuild polyfills and modules

feat(runtime): add polyfill for `fetch` api
chore(graalvm): rebuild polyfills and modules

Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon sgammon added feature Large PRs or issues with full-blown features lang:javascript Issues relating to JavaScript api:node Node API and stdlib labels Feb 23, 2025
@sgammon sgammon added this to the Release R7: Beta 1 milestone Feb 23, 2025
@sgammon sgammon self-assigned this Feb 23, 2025
@sgammon sgammon changed the title feat(graalvm): add polyfilled fetch support feat: add polyfilled fetch support Feb 23, 2025
@sgammon sgammon requested a review from a team February 23, 2025 05:04
Copy link

codecov bot commented Feb 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.17%. Comparing base (c00e776) to head (1c66a5d).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1229   +/-   ##
=======================================
  Coverage   53.16%   53.17%           
=======================================
  Files         429      429           
  Lines       17242    17244    +2     
  Branches     3125     3125           
=======================================
+ Hits         9167     9169    +2     
  Misses       7055     7055           
  Partials     1020     1020           
Flag Coverage Δ
jvm 53.17% <100.00%> (+<0.01%) ⬆️
lib 53.17% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ckages/cli/src/main/kotlin/elide/tool/cli/Elide.kt 28.33% <100.00%> (+0.60%) ⬆️
...de/runtime/core/internals/graalvm/GraalVMEngine.kt 83.78% <100.00%> (+0.11%) ⬆️
...main/kotlin/elide/runtime/plugins/js/JavaScript.kt 93.12% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c00e776...1c66a5d. Read the comment docs.

@sgammon sgammon merged commit 64d9c28 into main Feb 23, 2025
21 checks passed
@sgammon sgammon deleted the feat/fetch-polyfill branch February 23, 2025 05:52
@sgammon sgammon mentioned this pull request Mar 11, 2025
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api:node Node API and stdlib feature Large PRs or issues with full-blown features lang:javascript Issues relating to JavaScript
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants