Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop proto packages #1239

Closed
wants to merge 1 commit into from
Closed

chore: drop proto packages #1239

wants to merge 1 commit into from

Conversation

sgammon
Copy link
Member

@sgammon sgammon commented Feb 24, 2025

Ready for review Powered by Pull Request Badge

Summary

Drops all of Elide's packages under packages/proto, since they were gross and unused anyway; consolidates generated protobuf code into graalvm so it can be accessed by that module and server (it is still in use by VFS).

Changelog

chore: move protobuf plugin and related wiring to `graalvm` module
chore: move generated protobufs to `graalvm` module
chore: drop all `proto-*` packages from project

chore: move protobuf plugin and related wiring to `graalvm` module
chore: move generated protobufs to `graalvm` module
chore: drop all `proto-*` packages from project

Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon sgammon added the dev Dev tools, CI/CD, and other devops topics label Feb 24, 2025
@sgammon sgammon added this to the Release R7: Beta 1 milestone Feb 24, 2025
@sgammon sgammon self-assigned this Feb 24, 2025
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.47%. Comparing base (adbbb99) to head (177c644).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1239      +/-   ##
==========================================
+ Coverage   52.17%   53.47%   +1.29%     
==========================================
  Files         435      435              
  Lines       17531    17531              
  Branches     3136     3137       +1     
==========================================
+ Hits         9147     9374     +227     
+ Misses       7354     7110     -244     
- Partials     1030     1047      +17     
Flag Coverage Δ
jvm 53.47% <ø> (+1.29%) ⬆️
lib 53.47% <ø> (+1.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 17 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adbbb99...177c644. Read the comment docs.

@sgammon sgammon closed this Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Dev tools, CI/CD, and other devops topics
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant