Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graalvm): omnibus native fixes #1244

Merged
merged 6 commits into from
Feb 24, 2025
Merged

fix(graalvm): omnibus native fixes #1244

merged 6 commits into from
Feb 24, 2025

Conversation

sgammon
Copy link
Member

@sgammon sgammon commented Feb 24, 2025

Ready for review Powered by Pull Request Badge

Summary

General suite of fixes for CLI error printing, issues with the native build introduced by dependency updates, and other chores. Error reporting gets a lot better with this PR.

Before and after:
image

Changelog

feat(cli): color support for error printing
fix(cli): don't swallow non-polyglot errors
fix(cli): show verbose errors in debug/verbose mode
fix(cli): error messages break length limits sometimes
fix(cli): errors in general get really long
fix(cli): errors show lots of irrelevant stacktrace entries
fix(graalvm): issues with elide-prefixed module names
fix(graalvm): truffle boundary for synthetic modules
fix(graalvm-js): drop superfluous log line
fix(graalvm-kt): language resources for kotlinc
chore: relock dependencies
chore: update kdl lock
chore: update gz configs for js/kt runtimes

@sgammon sgammon added bug Something isn't working dependencies Pull requests that update a dependency file dev Dev tools, CI/CD, and other devops topics labels Feb 24, 2025
@sgammon sgammon added this to the Release R7: Beta 1 milestone Feb 24, 2025
@sgammon sgammon self-assigned this Feb 24, 2025
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 5.79710% with 130 lines in your changes missing coverage. Please review.

Project coverage is 50.80%. Comparing base (667c882) to head (bc1edbc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...s/cli/src/main/kotlin/elide/tool/err/ErrPrinter.kt 0.00% 89 Missing ⚠️
...kotlin/elide/tool/cli/cmd/repl/ToolShellCommand.kt 0.00% 32 Missing ⚠️
...elide/runtime/gvm/internals/sqlite/SqliteModule.kt 58.33% 4 Missing and 1 partial ⚠️
...me/lang/javascript/ElideUniversalJsModuleLoader.kt 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1244      +/-   ##
==========================================
- Coverage   51.20%   50.80%   -0.40%     
==========================================
  Files         458      459       +1     
  Lines       17927    18037     +110     
  Branches     3181     3195      +14     
==========================================
- Hits         9179     9164      -15     
- Misses       7714     7842     +128     
+ Partials     1034     1031       -3     
Flag Coverage Δ
jvm 50.80% <5.79%> (-0.40%) ⬇️
lib 50.80% <5.79%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ide/runtime/lang/javascript/ElideJsModuleRouter.kt 0.00% <ø> (ø)
...otlin/elide/runtime/plugins/js/JavaScriptConfig.kt 95.34% <100.00%> (ø)
...me/lang/javascript/ElideUniversalJsModuleLoader.kt 0.00% <0.00%> (ø)
...elide/runtime/gvm/internals/sqlite/SqliteModule.kt 82.99% <58.33%> (-0.95%) ⬇️
...kotlin/elide/tool/cli/cmd/repl/ToolShellCommand.kt 22.98% <0.00%> (-0.21%) ⬇️
...s/cli/src/main/kotlin/elide/tool/err/ErrPrinter.kt 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 667c882...bc1edbc. Read the comment docs.

@sgammon sgammon force-pushed the fix/native-build branch 2 times, most recently from 09ba0f3 to b54fae3 Compare February 24, 2025 12:54
sgammon and others added 6 commits February 24, 2025 14:06
feat(cli): color support for error printing
fix(cli): don't swallow non-polyglot errors
fix(cli): show verbose errors in debug/verbose mode
fix(cli): error messages break length limits sometimes
fix(cli): errors in general get really long
fix(cli): errors show lots of irrelevant stacktrace entries
fix(graalvm): issues with elide-prefixed module names
fix(graalvm): truffle boundary for synthetic modules
fix(graalvm-js): drop superfluous log line
fix(graalvm-kt): language resources for kotlinc
chore: relock dependencies
chore: update kdl lock
chore: update gz configs for js/kt runtimes

Fixes and closes #1049

Signed-off-by: Sam Gammon <sam@elide.dev>
Bumps [slsa-framework/slsa-github-generator](https://github.com/slsa-framework/slsa-github-generator) from 2.0.0 to 2.1.0.
- [Release notes](https://github.com/slsa-framework/slsa-github-generator/releases)
- [Changelog](https://github.com/slsa-framework/slsa-github-generator/blob/main/CHANGELOG.md)
- [Commits](slsa-framework/slsa-github-generator@v2.0.0...v2.1.0)

---
updated-dependencies:
- dependency-name: slsa-framework/slsa-github-generator
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Sam Gammon <sam@elide.dev>
Bumps [pnpm/action-setup](https://github.com/pnpm/action-setup) from 4.0.0 to 4.1.0.
- [Release notes](https://github.com/pnpm/action-setup/releases)
- [Commits](pnpm/action-setup@fe02b34...a7487c7)

---
updated-dependencies:
- dependency-name: pnpm/action-setup
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Sam Gammon <sam@elide.dev>
Bumps [JetBrains/qodana-action](https://github.com/jetbrains/qodana-action) from 12ec1e736e5f012abe0eea9fe83c33d4a88eddd3 to fe012aed54dc21daa5df0108f7b51305a2877251.
- [Release notes](https://github.com/jetbrains/qodana-action/releases)
- [Commits](JetBrains/qodana-action@12ec1e7...fe012ae)

---
updated-dependencies:
- dependency-name: JetBrains/qodana-action
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Sam Gammon <sam@elide.dev>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.6.0 to 4.6.1.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@65c4c4a...4cec3d8)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Sam Gammon <sam@elide.dev>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.28.8 to 3.28.10.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@dd74661...b56ba49)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon sgammon merged commit cf62b54 into main Feb 24, 2025
23 checks passed
@sgammon sgammon deleted the fix/native-build branch February 24, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file dev Dev tools, CI/CD, and other devops topics
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant