Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for queueMicrotask #1266

Merged
merged 1 commit into from
Mar 9, 2025
Merged

feat: add support for queueMicrotask #1266

merged 1 commit into from
Mar 9, 2025

Conversation

sgammon
Copy link
Member

@sgammon sgammon commented Mar 9, 2025

Ready for review Powered by Pull Request Badge

Summary

Name's on the tin. Closes #1265.

  • Add queueMicrotask
  • Amend globals tests to include queueMicrotask
  • Tests for queueMicrotask

Changelog

- feat(graalvm): add support for `queueMicrotask`
- test(graalvm): tests for `queueMicrotask`

@sgammon sgammon added lang:javascript Issues relating to JavaScript tc:winter WinterTC Spec labels Mar 9, 2025
@sgammon sgammon added this to the Release R7: Beta 1 milestone Mar 9, 2025
@sgammon sgammon self-assigned this Mar 9, 2025
Copy link

codecov bot commented Mar 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.23%. Comparing base (ab3eccc) to head (c8a7806).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1266      +/-   ##
==========================================
+ Coverage   48.20%   48.23%   +0.03%     
==========================================
  Files         498      499       +1     
  Lines       18263    18273      +10     
  Branches     3231     3233       +2     
==========================================
+ Hits         8803     8814      +11     
+ Misses       8430     8429       -1     
  Partials     1030     1030              
Flag Coverage Δ
jvm 48.23% <100.00%> (+0.03%) ⬆️
lib 48.23% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../main/kotlin/elide/runtime/core/PolyglotContext.kt 0.00% <ø> (ø)
...gvm/internals/intrinsics/js/AbstractJsIntrinsic.kt 80.00% <100.00%> (ø)
...elide/runtime/javascript/QueueMicrotaskCallable.kt 100.00% <100.00%> (ø)
...main/kotlin/elide/runtime/plugins/js/Extensions.kt 77.77% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab3eccc...c8a7806. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sgammon sgammon force-pushed the feat/queue-microtask branch from 7097c3e to dc7c24c Compare March 9, 2025 03:42
feat(graalvm): add support for `queueMicrotask`
test(graalvm): add tests for `queueMicrotask`

Fixes and closes #1265

Relates-to: #1265
Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon sgammon force-pushed the feat/queue-microtask branch from dc7c24c to c8a7806 Compare March 9, 2025 04:06
@sgammon sgammon requested a review from a team March 9, 2025 04:21
@sgammon sgammon merged commit 92f33da into main Mar 9, 2025
18 checks passed
@sgammon sgammon deleted the feat/queue-microtask branch March 9, 2025 05:58
@sgammon sgammon mentioned this pull request Mar 11, 2025
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang:javascript Issues relating to JavaScript tc:winter WinterTC Spec
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

JS API: queueMicrotask support
1 participant