Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): native image boot to repl #1271

Merged
merged 1 commit into from
Mar 9, 2025
Merged

fix(cli): native image boot to repl #1271

merged 1 commit into from
Mar 9, 2025

Conversation

sgammon
Copy link
Member

@sgammon sgammon commented Mar 9, 2025

Ready for review Powered by Pull Request Badge

Summary

Fixes a crash at current release experienced when starting the main JS REPL. Closes #1270.

Fixes and closes #1270

Relates-to: #1270
Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon sgammon added bug Something isn't working P0 labels Mar 9, 2025
@sgammon sgammon added this to the Release R7: Beta 1 milestone Mar 9, 2025
@sgammon sgammon self-assigned this Mar 9, 2025
@sgammon sgammon requested a review from a team March 9, 2025 04:21
Copy link

codecov bot commented Mar 9, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.20%. Comparing base (ab3eccc) to head (c963a80).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...de/runtime/core/internals/graalvm/GraalVMEngine.kt 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1271   +/-   ##
=======================================
  Coverage   48.20%   48.20%           
=======================================
  Files         498      498           
  Lines       18263    18265    +2     
  Branches     3231     3232    +1     
=======================================
+ Hits         8803     8804    +1     
- Misses       8430     8434    +4     
+ Partials     1030     1027    -3     
Flag Coverage Δ
jvm 48.20% <66.66%> (+<0.01%) ⬆️
lib 48.20% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...de/runtime/core/internals/graalvm/GraalVMEngine.kt 67.74% <66.66%> (-0.20%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab3eccc...c963a80. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sgammon sgammon merged commit 4e064b3 into main Mar 9, 2025
18 checks passed
@sgammon sgammon deleted the fix/repl-crash branch March 9, 2025 05:58
@sgammon sgammon mentioned this pull request Mar 11, 2025
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P0
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

REPL is broken at 1.0.0-alpha14
1 participant