Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graalvm): add support for navigator.userAgent #1277

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Conversation

sgammon
Copy link
Member

@sgammon sgammon commented Mar 10, 2025

Ready for review Powered by Pull Request Badge

Summary

Adds navigator.userAgent to the JS context.

Closes #1275

Relates-to: #1275
Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon sgammon added lang:javascript Issues relating to JavaScript api:node Node API and stdlib tc:winter WinterTC Spec labels Mar 10, 2025
@sgammon sgammon added this to the Release R7: Beta 1 milestone Mar 10, 2025
@sgammon sgammon self-assigned this Mar 10, 2025
@sgammon sgammon linked an issue Mar 10, 2025 that may be closed by this pull request
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 48.24%. Comparing base (9d9be0e) to head (4bac742).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...otlin/elide/runtime/javascript/NavigatorBuiltin.kt 64.28% 4 Missing and 1 partial ⚠️
...vm/src/main/kotlin/elide/runtime/gvm/js/JsError.kt 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1277   +/-   ##
=======================================
  Coverage   48.24%   48.24%           
=======================================
  Files         499      500    +1     
  Lines       18277    18295   +18     
  Branches     3234     3236    +2     
=======================================
+ Hits         8817     8826    +9     
- Misses       8433     8441    +8     
- Partials     1027     1028    +1     
Flag Coverage Δ
jvm 48.24% <50.00%> (+<0.01%) ⬆️
lib 48.24% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...vm/src/main/kotlin/elide/runtime/gvm/js/JsError.kt 30.00% <0.00%> (-2.61%) ⬇️
...otlin/elide/runtime/javascript/NavigatorBuiltin.kt 64.28% <64.28%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d9be0e...4bac742. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sgammon sgammon merged commit e0d3962 into main Mar 10, 2025
18 checks passed
@sgammon sgammon deleted the feat/navigator-api branch March 10, 2025 04:11
@sgammon sgammon mentioned this pull request Mar 11, 2025
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api:node Node API and stdlib lang:javascript Issues relating to JavaScript tc:winter WinterTC Spec
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

JS API: Navigator
1 participant