Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reflection issues with fetch #1279

Merged
merged 7 commits into from
Mar 10, 2025
Merged

fix: reflection issues with fetch #1279

merged 7 commits into from
Mar 10, 2025

Conversation

sgammon
Copy link
Member

@sgammon sgammon commented Mar 10, 2025

Ready for review Powered by Pull Request Badge

Summary

Fixes some reflection issues with fetch, and adds some improved error handling within the CLI; also adds an experimental feature to warm preamble scripts at build time (by parsing their sources statically).

sgammon added 6 commits March 10, 2025 00:10
- chore: move `creative` and `docs` dirs to new project dir
- test: add smoke test runs for code in `tools/scripts`

Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon sgammon added bug Something isn't working 🧪 labs Experimental work lang:javascript Issues relating to JavaScript labels Mar 10, 2025
@sgammon sgammon added this to the Release R7: Beta 1 milestone Mar 10, 2025
@sgammon sgammon self-assigned this Mar 10, 2025
Signed-off-by: Sam Gammon <sam@elide.dev>
@sgammon sgammon enabled auto-merge (rebase) March 10, 2025 12:12
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 5.47945% with 69 lines in your changes missing coverage. Please review.

Project coverage is 48.40%. Comparing base (e0d3962) to head (ee32e56).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...in/elide/runtime/plugins/AbstractLanguagePlugin.kt 0.00% 38 Missing ⚠️
...kotlin/elide/tool/cli/cmd/repl/ToolShellCommand.kt 0.00% 31 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1279      +/-   ##
==========================================
+ Coverage   48.24%   48.40%   +0.16%     
==========================================
  Files         500      500              
  Lines       18295    18365      +70     
  Branches     3236     3265      +29     
==========================================
+ Hits         8826     8890      +64     
- Misses       8441     8462      +21     
+ Partials     1028     1013      -15     
Flag Coverage Δ
jvm 48.40% <5.47%> (+0.16%) ⬆️
lib 48.40% <5.47%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...main/kotlin/elide/runtime/plugins/js/JavaScript.kt 96.22% <100.00%> (+0.10%) ⬆️
...kotlin/elide/tool/cli/cmd/repl/ToolShellCommand.kt 42.06% <0.00%> (-1.64%) ⬇️
...in/elide/runtime/plugins/AbstractLanguagePlugin.kt 0.00% <0.00%> (ø)

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0d3962...ee32e56. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sgammon sgammon merged commit fcf5cdf into main Mar 10, 2025
18 checks passed
@sgammon sgammon deleted the chore/cleanup-pt2 branch March 10, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🧪 labs Experimental work lang:javascript Issues relating to JavaScript
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant