Turn aggressive nomination off by default

Author: mickel8

lib/ex_ice/ice_agent.ex

@@ -66,7 +66,7 @@ defmodule ExICE.ICEAgent do
   In particular, RFC 8445 assumes that data can be sent on any valid pair (there is no need for nomination).
   While this behavior is supported by most of the implementations, some of them still require
   a pair to be nominated by the controlling agent before they can start sending data.
-  Defaults to true.
+  Defaults to false.
   * `on_gathering_state_change` - where to send gathering state change notifications. Defaults to a process that spawns `ExICE`.
   * `on_connection_state_change` - where to send connection state change notifications. Defaults to a process that spawns `ExICE`.
   * `on_data` - where to send data. Defaults to a process that spawns `ExICE`.

lib/ex_ice/priv/ice_agent.ex

@@ -151,7 +151,7 @@ defmodule ExICE.Priv.ICEAgent do
       on_gathering_state_change: opts[:on_gathering_state_change] || controlling_process,
       on_data: opts[:on_data] || controlling_process,
       on_new_candidate: opts[:on_new_candidate] || controlling_process,
-      aggressive_nomination: Keyword.get(opts, :aggressive_nomination, true),
+      aggressive_nomination: Keyword.get(opts, :aggressive_nomination, false),
       if_discovery_module: if_discovery_module,
       transport_module: transport_module,
       gatherer: Gatherer.new(if_discovery_module, transport_module, ip_filter, ports),