Skip to content

Commit 597b1a4

Browse files
authored
Merge pull request #1098 from elwayman02/ember-5.11
Ember 5.11 Blueprint Updates
2 parents 4834ab3 + b64e226 commit 597b1a4

14 files changed

+516
-210
lines changed

.ember-cli

-8
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,4 @@
11
{
2-
/**
3-
Ember CLI sends analytics information by default. The data is completely
4-
anonymous, but there are times when you might want to disable this behavior.
5-
6-
Setting `disableAnalytics` to true will prevent any data from being sent.
7-
*/
8-
"disableAnalytics": false,
9-
102
/**
113
Setting `isTypeScriptProject` to true will force the blueprint generators to generate TypeScript
124
rather than JavaScript by default, when a TypeScript version of a given blueprint is available.

.eslintignore

+1-12
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,14 @@
11
# unconventional js
22
/blueprints/*/files/
3-
/vendor/
43

54
# compiled output
5+
/declarations/
66
/dist/
7-
/tmp/
8-
9-
# dependencies
10-
/bower_components/
11-
/node_modules/
127

138
# misc
149
/coverage/
1510
!.*
1611
.*/
17-
.eslintcache
1812

1913
# ember-try
2014
/.node_modules.ember-try/
21-
/bower.json.ember-try
22-
/npm-shrinkwrap.json.ember-try
23-
/package.json.ember-try
24-
/package-lock.json.ember-try
25-
/yarn.lock.ember-try

.github/workflows/ci.yml

+2
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,8 @@ jobs:
5454
try-scenario:
5555
- ember-lts-4.4
5656
- ember-lts-4.8
57+
- ember-lts-4.12
58+
- ember-lts-5.4
5759
- ember-release
5860
- embroider-safe
5961
experimental: [false]

.gitignore

+1-8
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,21 @@
1-
# See https://help.github.com/ignore-files/ for more about ignoring files.
2-
31
# compiled output
42
/dist/
5-
/tmp/
3+
/declarations/
64

75
# dependencies
8-
/bower_components/
96
/node_modules/
107

118
# misc
129
/.env*
1310
/.pnp*
14-
/.sass-cache
1511
/.eslintcache
16-
/connect.lock
1712
/coverage/
18-
/libpeerconnection.log
1913
/npm-debug.log*
2014
/testem.log
2115
/yarn-error.log
2216

2317
# ember-try
2418
/.node_modules.ember-try/
25-
/bower.json.ember-try
2619
/npm-shrinkwrap.json.ember-try
2720
/package.json.ember-try
2821
/package-lock.json.ember-try

.npmignore

+2-6
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,7 @@
22
/dist/
33
/tmp/
44

5-
# dependencies
6-
/bower_components/
7-
85
# misc
9-
/.bowerrc
106
/.editorconfig
117
/.ember-cli
128
/.env*
@@ -23,11 +19,12 @@
2319
/.template-lintrc.js
2420
/.travis.yml
2521
/.watchmanconfig
26-
/bower.json
2722
/CONTRIBUTING.md
2823
/ember-cli-build.js
2924
/testem.js
3025
/tests/
26+
/tsconfig.declarations.json
27+
/tsconfig.json
3128
/yarn-error.log
3229
/yarn.lock
3330
/.yarn
@@ -36,7 +33,6 @@
3633

3734
# ember-try
3835
/.node_modules.ember-try/
39-
/bower.json.ember-try
4036
/npm-shrinkwrap.json.ember-try
4137
/package.json.ember-try
4238
/package-lock.json.ember-try

.prettierignore

+1-13
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,13 @@
11
# unconventional js
22
/blueprints/*/files/
3-
/vendor/
43

54
# compiled output
65
/dist/
7-
/tmp/
8-
9-
# dependencies
10-
/bower_components/
11-
/node_modules/
126

137
# misc
148
/coverage/
159
!.*
16-
.eslintcache
17-
.lint-todo/
10+
.*/
1811

1912
# ember-try
2013
/.node_modules.ember-try/
21-
/bower.json.ember-try
22-
/npm-shrinkwrap.json.ember-try
23-
/package.json.ember-try
24-
/package-lock.json.ember-try
25-
/yarn.lock.ember-try

.watchmanconfig

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
{
2-
"ignore_dirs": ["tmp", "dist"]
2+
"ignore_dirs": ["dist"]
33
}

CONTRIBUTING.md

+7-7
Original file line numberDiff line numberDiff line change
@@ -8,18 +8,18 @@
88

99
## Linting
1010

11-
* `yarn lint`
12-
* `yarn lint:fix`
11+
- `yarn lint`
12+
- `yarn lint:fix`
1313

1414
## Running tests
1515

16-
* `ember test` – Runs the test suite on the current Ember version
17-
* `ember test --server` – Runs the test suite in "watch mode"
18-
* `ember try:each` – Runs the test suite against multiple Ember versions
16+
- `yarn test` – Runs the test suite on the current Ember version
17+
- `yarn test:ember --server` – Runs the test suite in "watch mode"
18+
- `yarn test:ember-compatibility` – Runs the test suite against multiple Ember versions
1919

2020
## Running the dummy application
2121

22-
* `ember serve`
23-
* Visit the dummy application at [http://localhost:4200](http://localhost:4200).
22+
- `yarn start`
23+
- Visit the dummy application at [http://localhost:4200](http://localhost:4200).
2424

2525
For more information on using ember-cli, visit [https://cli.emberjs.com/release/](https://cli.emberjs.com/release/).

README.md

+1-5
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,11 @@ Check out the [documentation](https://ember-scroll-modifiers.jhawk.co/)!
88

99
We adhere to the [Ember Community Guidelines](https://emberjs.com/guidelines/) for our Code of Conduct.
1010

11-
1211
## Compatibility
1312

1413
* Ember.js v4.4 or above
1514
* Ember CLI v4.4 or above
16-
* Node.js v14 or above
15+
* Node.js v18 or above
1716
* [All N-1 Browsers](https://caniuse.com/#feat=intersectionobserver)
1817

1918

@@ -23,17 +22,14 @@ We adhere to the [Ember Community Guidelines](https://emberjs.com/guidelines/) f
2322
ember install ember-scroll-modifiers
2423
```
2524

26-
2725
## Usage
2826

2927
[Longer description of how to use the addon in apps.]
3028

31-
3229
## Contributing
3330

3431
See the [Contributing](CONTRIBUTING.md) guide for details.
3532

36-
3733
## License
3834

3935
This project is licensed under the [MIT License](LICENSE.md).

package.json

+16-15
Original file line numberDiff line numberDiff line change
@@ -17,21 +17,21 @@
1717
},
1818
"scripts": {
1919
"build": "ember build --environment=production",
20-
"lint": "concurrently \"npm:lint:*(!fix|hbs)\" --names \"lint:\"",
20+
"lint": "concurrently \"yarn:lint:*(!fix|hbs)\" --names \"lint:\"",
2121
"lint:css": "stylelint \"**/*.css\"",
22-
"lint:css:fix": "concurrently \"npm:lint:css -- --fix\"",
23-
"lint:fix": "concurrently \"npm:lint:*:fix\" --names \"fix:\"",
22+
"lint:css:fix": "concurrently \"yarn:lint:css -- --fix\"",
23+
"lint:fix": "concurrently \"yarn:lint:*:fix\" --names \"fix:\"",
2424
"lint:hbs": "ember-template-lint .",
2525
"lint:hbs:fix": "ember-template-lint . --fix",
2626
"lint:js": "eslint . --cache",
2727
"lint:js:fix": "eslint . --fix",
2828
"start": "ember serve",
29-
"test": "concurrently \"npm:lint\" \"npm:test:*\" --names \"lint,test:\"",
29+
"test": "concurrently \"yarn:lint\" \"yarn:test:*\" --names \"lint,test:\"",
3030
"test:ember": "ember test",
3131
"test:ember-compatibility": "ember try:each"
3232
},
3333
"dependencies": {
34-
"ember-auto-import": "^2.6.3",
34+
"ember-auto-import": "^2.7.4",
3535
"ember-cli-babel": "^7.26.11",
3636
"ember-cli-htmlbars": "^6.3.0",
3737
"ember-modifier": "^4.1.0",
@@ -41,15 +41,16 @@
4141
"@babel/eslint-parser": "^7.25.1",
4242
"@babel/plugin-proposal-decorators": "^7.24.7",
4343
"@babel/plugin-transform-class-static-block": "^7.24.7",
44-
"@ember/optional-features": "^2.0.0",
44+
"@ember/optional-features": "^2.1.0",
4545
"@ember/string": "^3.0.1",
46-
"@ember/test-helpers": "^2.9.4",
46+
"@ember/test-helpers": "^3.3.1",
4747
"@embroider/test-setup": "^4.0.0",
4848
"@glimmer/component": "^1.1.2",
4949
"@glimmer/tracking": "^1.1.2",
5050
"broccoli-asset-rev": "^3.0.0",
5151
"concurrently": "^8.2.2",
5252
"ember-cli": "~5.11.0",
53+
"ember-cli-clean-css": "^3.0.0",
5354
"ember-cli-dependency-checker": "^3.3.2",
5455
"ember-cli-deprecation-workflow": "^2.0.0",
5556
"ember-cli-fastboot": "^4.1.1",
@@ -61,32 +62,32 @@
6162
"ember-fetch": "^8.1.2",
6263
"ember-load-initializers": "^2.1.2",
6364
"ember-page-title": "^8.2.3",
64-
"ember-qunit": "^6.2.0",
65+
"ember-qunit": "^8.1.0",
6566
"ember-resolver": "^11.0.1",
6667
"ember-sinon-qunit": "^6.0.0",
67-
"ember-source": "~5.0.0",
68+
"ember-source": "~5.11.0",
6869
"ember-source-channel-url": "^3.0.0",
6970
"ember-template-lint": "^6.0.0",
7071
"ember-try": "^3.0.0",
7172
"eslint": "^8.57.0",
72-
"eslint-config-prettier": "^9.0.0",
73-
"eslint-plugin-ember": "^11.11.1",
73+
"eslint-config-prettier": "^9.1.0",
74+
"eslint-plugin-ember": "^11.12.0",
7475
"eslint-plugin-n": "^17.10.2",
75-
"eslint-plugin-prettier": "^5.1.3",
76-
"eslint-plugin-qunit": "^8.0.1",
76+
"eslint-plugin-prettier": "^5.2.1",
77+
"eslint-plugin-qunit": "^8.1.1",
7778
"field-guide": "^2.4.0",
7879
"field-guide-default-template": "^3.0.0",
7980
"loader.js": "^4.7.0",
8081
"prember": "^2.0.0",
8182
"prettier": "^3.3.3",
82-
"qunit": "^2.20.0",
83+
"qunit": "^2.22.0",
8384
"qunit-dom": "^3.2.0",
8485
"release-it": "^15.11.0",
8586
"release-it-lerna-changelog": "^5.0.0",
8687
"sass": "^1.77.8",
8788
"stylelint": "^15.11.0",
8889
"stylelint-config-standard": "^34.0.0",
89-
"stylelint-prettier": "^4.0.2",
90+
"stylelint-prettier": "^4.1.0",
9091
"webpack": "^5.93.0"
9192
},
9293
"fastbootDependencies": [

tests/dummy/config/ember-cli-update.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"packages": [
44
{
55
"name": "ember-cli",
6-
"version": "4.12.1",
6+
"version": "5.11.0",
77
"blueprints": [
88
{
99
"name": "addon",

tests/dummy/config/ember-try.js

+16
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,22 @@ module.exports = async function () {
2323
},
2424
},
2525
},
26+
{
27+
name: 'ember-lts-4.12',
28+
npm: {
29+
devDependencies: {
30+
'ember-source': '~4.12.0',
31+
},
32+
},
33+
},
34+
{
35+
name: 'ember-lts-5.4',
36+
npm: {
37+
devDependencies: {
38+
'ember-source': '~5.4.0',
39+
},
40+
},
41+
},
2642
{
2743
name: 'ember-release',
2844
npm: {

tests/helpers/index.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import {
44
setupTest as upstreamSetupTest,
55
} from 'ember-qunit';
66

7-
// This file exists to provide wrappers around ember-qunit's / ember-mocha's
7+
// This file exists to provide wrappers around ember-qunit's
88
// test setup functions. This way, you can easily extend the setup that is
99
// needed per test type.
1010

@@ -23,7 +23,7 @@ function setupApplicationTest(hooks, options) {
2323
// This is also a good place to call test setup functions coming
2424
// from other addons:
2525
//
26-
// setupIntl(hooks); // ember-intl
26+
// setupIntl(hooks, 'en-us'); // ember-intl
2727
// setupMirage(hooks); // ember-cli-mirage
2828
}
2929

0 commit comments

Comments
 (0)