Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove assert.expect from tests #398

Open
elwayman02 opened this issue Jun 24, 2021 · 0 comments
Open

Remove assert.expect from tests #398

elwayman02 opened this issue Jun 24, 2021 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed internal Internal changes that don't affect public API

Comments

@elwayman02
Copy link
Owner

Nearly all of our tests call assertions synchronously - that is, they aren't wrapped in callbacks or other scenarios where it's possible that one or more of the assertions won't get called. As a result, using assert.expect becomes unnecessary, since we'll never have a scenario where only some of the assertions get run. We should remove assert.expect from all tests of this nature to make our tests less brittle to future changes.

@elwayman02 elwayman02 added help wanted Extra attention is needed good first issue Good for newcomers internal Internal changes that don't affect public API labels Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed internal Internal changes that don't affect public API
Projects
None yet
Development

No branches or pull requests

1 participant